1911931 - [wpt-sync] Sync PR 47502 - [line-clamp] Allow clamp points after IFCs

Status: RESOLVED FIXED

(Core :: Layout: Scrolling and Overflow, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 47502 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/47502
Details from upstream follow.

Andreu Botella <[e-mail]> wrote:

[line-clamp] Allow clamp points after IFCs

For -webkit-line-clamp (and line-clamp with a number of lines),
the only place that could have a clamp point is after a line, so the
only place that calls BlockLineClampData::UpdateAfterLayout in
Chromium code is after laying out an in-flow child. When
line-clamp: auto was implemented, which can also clamp after a
block-level box, this call to UpdateAfterLayout also handled
clamping after such children boxes, when they were in-flow.

However, clamping after a new IFC was not tested until now, and as it
turns out it did not work, because UpdateAfterLayout was not called
in the equivalent code in HandleNewFormattingContext. This patch
fixes that.

Bug: 40336192
Change-Id: I7b67be2c64f95d3effdd15a6e348e6cde7ac8976
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5766555
Commit-Queue: Andreu Botella \<[e-mail]>
Reviewed-by: Ian Kilpatrick \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1338198}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=707775ccb439a051eca5bb9d331d054462633bab

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

FAIL: 2

Chrome

PASS: 1
FAIL: 1

Safari

FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-overflow/line-clamp/line-clamp-auto-033.tentative.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: FAIL)
• /css/css-overflow/line-clamp/line-clamp-auto-034.tentative.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4320692f6d3
[wpt PR 47502] - [line-clamp] Allow clamp points after IFCs, a=testonly
https://hg.mozilla.org/integration/autoland/rev/49614b2c9977
[wpt PR 47502] - Update wpt metadata, a=testonly

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/a4320692f6d3
https://hg.mozilla.org/mozilla-central/rev/49614b2c9977