1911938 - [wpt-sync] Sync PR 47503 - [Masonry] Add masonry display type

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 47503 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/47503
Details from upstream follow.

Ethan Jimenez <[e-mail]> wrote:

[Masonry] Add masonry display type

1. Introducing parsing for the new masonry and inline-masonry values
   for display, mapping them to their respective EDisplay enums.

2. Renaming feature flag to CSSMasonryLayout.

3. Adding test coverage for parsing of these tentative new values.

Bug: 343257585
Change-Id: I076c31c48da249a42e939e4d9a9001c6d9743396
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5750163
Reviewed-by: Ian Kilpatrick \<[e-mail]>
Reviewed-by: Alison Maher \<[e-mail]>
Commit-Queue: Ethan Jimenez \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1338207}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=8204dbf97ddd5ad9e10cd712749f2b78ed965624

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 2 subtests

Status Summary

Firefox

OK : 2
FAIL: 8

Chrome

OK : 2
FAIL: 8

Safari

OK : 2
FAIL: 8

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-display/parsing/tentative/display-computed.html [wpt.fyi]
  • Property display value 'masonry': FAIL (Chrome: FAIL, Safari: FAIL)
  • Property display value 'inline-masonry': FAIL (Chrome: FAIL, Safari: FAIL)
  • position absolute affects computed display: FAIL (Chrome: FAIL, Safari: FAIL)
  • position fixed affects computed display: FAIL (Chrome: FAIL, Safari: FAIL)
  • float left affects computed display: FAIL (Chrome: FAIL, Safari: FAIL)
  • float right affects computed display: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-display/parsing/tentative/display-valid.html [wpt.fyi]
  • e.style['display'] = "masonry" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
  • e.style['display'] = "inline-masonry" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/800969939d0e
[wpt PR 47503] - [Masonry] Add masonry display type, a=testonly
https://hg.mozilla.org/integration/autoland/rev/60c45993ffb2
[wpt PR 47503] - Update wpt metadata, a=testonly

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/800969939d0e
https://hg.mozilla.org/mozilla-central/rev/60c45993ffb2