1912024 - Disable/enable ML in all the existing pdf viewers

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[Calixte Denizet (:calixte)]

STR:

• enable ML;
• open two pdfs in two different tabs;
• in one tab add an image;
• in the other tab, disable ML thanks to the image settings in the secondary menu.

Expected results:
The request in the first tab must be cancelled.

Actual results:
The request isn't cancelled.

Comment 1

[BMO Github Automation]

Attachment: [mozilla/pdf.js] [Editor] Dispatch changes in prefs enableAltTextModelDownload and enableGuessAltText to the viewer (bug 1912024) (#18573)

Comment 2

[Calixte Denizet (:calixte)]

Attachment: Bug 1912024 - Observe prefs pdfjs.(enableGuessAltText|enableAltTextModelDownload) in order to update the different pdf viewers r=#pdfjs-reviewers

The user can change a ML pref in a viewer and it'll have an effect in all other viewers.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/771b623ee740
Observe prefs pdfjs.(enableGuessAltText|enableAltTextModelDownload) in order to update the different pdf viewers r=pdfjs-reviewers,marco

Comment 4

[BMO Github Automation]

Attachment: [mozilla/pdf.js] Revert "[Editor] Dispatch changes in prefs enableAltTextModelDownload and enableGuessAltText to the viewer (bug 1912024)" (#18578)

Comment 5

[BMO Github Automation]

Attachment: [mozilla/pdf.js] Dispatch changes in prefs enableAltTextModelDownload and enableGuessAltText to the viewer (bug 1912024) (#18579)

Comment 6

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/771b623ee740

Comment 7

[Rares Doghi, Desktop QA]

Hi @Calixte can you clear some of the steps from this issue ? what do you mean by Disable ML from the image settings in the secondary menu ? is it the Alt Text Settings modal ? if so should Turning off the Create Alt text Automatically stop the AI alt text from the first Tab with the added image ? because right now that only happens if we refresh the page.

Which im not even sure if its turned off or simply stopped working because of the "Refresh the page" bug.

Comment 8

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly 131.0a1 (2024-08-12) build due to Bug 1912601.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:calixte, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox130 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Calixte Denizet (:calixte)]

Attachment: Bug 1912024 - Observe prefs pdfjs.(enableGuessAltText|enableAltTextModelDownload) in order to update the different pdf viewers

The user can change a ML pref in a viewer and it'll have an effect in all other viewers.

Original Revision: https://phabricator.services.mozilla.com/D218748

Depends on D219261

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/69f8bd57cd69

Comment 12

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Beta 130.0b6