1912045 - Autofill for search restrict keywords

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P2)

Description

[Mandy Cheang [:mcheang][she/her] - Away Oct 5– Nov 9]

Description

• Add autofill functionality to UrlbarProvider Restrict Keywords.

Acceptance Criteria

• There are 3 restrict keywords @history, @bookmarks, and @tabs
• When the user types @ followed by the beginning of the search keyword: @h, @hi, @his, @hist etc. the user should be able to autofill the rest of the search by pressing tab
• The autofill should highlight the typed letters from the user, and show the entire keyword following what the user typed. For example:
• If the user typed @hist , autofill should highlight what the user typed and show the rest of the keyword @history:

Example steps to test @history :

• set browser.urlbar.searchRestrictKeywords.featureGate to true
• type out the full keyword and space @history , address bar should show results panel with history results
• type @h and press right arrow, shows results panel with history results
• type @h and press enter, shows results panel with history results
  - type @h and press tab, does not show panel but selects the history restrict result. When the user starts typing, it will search their history and show results panel with history results This behaviour changed in Bug 925532. Type @h and press tab, shows results panel with history results

Comment 1

[Mandy Cheang [:mcheang][she/her] - Away Oct 5– Nov 9]

Attachment: Bug 1912045 - Autofill for intuitive search keywords. r=daleharvey

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5cff57b6b5a2
Autofill for intuitive search keywords. r=daleharvey,urlbar-reviewers,mak

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/5cff57b6b5a2

Comment 4

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Hy Mandy!
I have a question regarding the autofill functionality.

The current behavior for autofill is that if a keyword is partially inserted in the urlbar ( eg. @h ) and then pressing TAB key, the results panel is now automatically displayed without any additional input.

Could you please confirm if the autofill behavior for restrict keywords has changed?
Thank you.

Comment 5

[Mandy Cheang [:mcheang][she/her] - Away Oct 5– Nov 9]

Hi Ardelean,

Yes, this is the intended behaviour now.
The bug that changed this is Bug 925532