1912051 - Improve naming of the test files used for search settings migration/loading tests

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

For the tests for the search service, we have a lot of settings files (approximately this list) that are used to check that settings are correctly loaded or migrated.

I think we should move these to their own directory, e.g. toolkit/components/search/tests/xpcshell/settings/ and rename them something along the lines of v1-wrong-default-engine-hashes.json. Having the version in there will help identify where we are testing migration from particular versions.

We'll likely need to dig into the tests and see if there's clearer names for some of these. We might also want to add a comment field at the top of the file with more information about what the file is intended for.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1912051 - Merge test_settings_ignorelist.js into test_ignorelist.js and improve the test. r?#search-reviewers!

test_settings_ignorelist.js didn't need to be separate. Additionally, it was not explicitly checking that the
engine from settings was not installed - it only checked that some engines were loaded successfully.

This also updates the settings file, and adds an additional OpenSearch type engine to be ignored.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1912051 - Move search settings test support files to a sub-directory. r?#search-reviewers!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a3f1c2d2def
Merge test_settings_ignorelist.js into test_ignorelist.js and improve the test. r=search-reviewers,daleharvey
https://hg.mozilla.org/integration/autoland/rev/b76472b1d15c
Move search settings test support files to a sub-directory. r=search-reviewers,daleharvey

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/7a3f1c2d2def
https://hg.mozilla.org/mozilla-central/rev/b76472b1d15c