1912068 - Refactor GC heap code in prepartion for adding slots/elements allocator

Status: RESOLVED FIXED

(Core :: JavaScript: GC, task)

Description

[Jon Coppeard (:jonco) (PTO until 14th September)]

This bug is for a bunch of refactoring patches written in preparation for bug 1911537.

Comment 1

[Jon Coppeard (:jonco) (PTO until 14th September)]

Attachment: Bug 1912068 - Part 1: Move NativeObject::isInWholeCellBuffer implementation to StoreBuffer r?jandem

gc/Heap-inl.h contains definitions that should be internal to the GC. This
change removes the need to inlude it in vm/NativeObject-inl.h which greatly
reduces the places it is included from.

Comment 2

[Jon Coppeard (:jonco) (PTO until 14th September)]

Attachment: Bug 1912068 - Part 2: Remove duplicate methods for checking mark bits r?jandem

Currently we have two different definitons for several methods that check mark
bits, one set being in the exported HeapAPI.j header and one set in gc/Heap.h.

This patch consolidates on a single definition for the ones that need to be
public and moves the remainder from gc/Heap.h (which gets included everywhere)
to the mostly internal gc/Heap-inl.h.

This also adds a copyFrom method.

Comment 3

[Jon Coppeard (:jonco) (PTO until 14th September)]

Attachment: Bug 1912068 - Part 3: Remove unused size parameter from tenured cell allocation methods r?jandem

This removes an unused parameter from CellAllocator::TryNewTenuredCell and
AllocTenuredCell.

Comment 4

[Jon Coppeard (:jonco) (PTO until 14th September)]

Attachment: Bug 1912068 - Part 4: Remove unnecessary inclusion of gc/Zone.h r?jandem

This greatly cuts down the number of files that include this header.

Comment 5

[Jon Coppeard (:jonco) (PTO until 14th September)]

Attachment: Bug 1912068 - Part 5: Make more Arena fields private r?jandem

This makes the zone and allocKind fields private and moves some methods that
release arenas into GCRuntime.

The Arena::next field is accessed by a bunch of different classes to put arenas
on various linked lists, so I left this public.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f80ab3f7857
Part 1: Move NativeObject::isInWholeCellBuffer implementation to StoreBuffer r=jandem
https://hg.mozilla.org/integration/autoland/rev/2cd958f1b0c3
Part 2: Remove duplicate methods for checking mark bits r=jandem
https://hg.mozilla.org/integration/autoland/rev/c0641d30ff1d
Part 3: Remove unused size parameter from tenured cell allocation methods r=jandem
https://hg.mozilla.org/integration/autoland/rev/99274a339703
Part 4: Remove unnecessary inclusion of gc/Zone.h r=jandem
https://hg.mozilla.org/integration/autoland/rev/af34a13f2688
Part 5: Make more Arena fields private r=jandem

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7f80ab3f7857
https://hg.mozilla.org/mozilla-central/rev/2cd958f1b0c3
https://hg.mozilla.org/mozilla-central/rev/c0641d30ff1d
https://hg.mozilla.org/mozilla-central/rev/99274a339703
https://hg.mozilla.org/mozilla-central/rev/af34a13f2688