1912080 - Chatbot prompt prefix string missing from localization

Status: VERIFIED FIXED

(Core :: Machine Learning: General, task)

Description

[Ed Lee :Mardak]

Attachment: it en-US prefix.png

[Tracking Requested - why for this release]: A string was missed from bug 1907350 as it's stored in a pref. flod suggests we should uplift this to 130 as people are likely to try this out in beta/release

Ania, is this something we should try to uplift vs only fix in nightly 131? The behavior should be correct in that it responds in the desired language, so it's more of a poor visual aspect for those who do look at the chat history but it is the very first thing shown. Should the expected number of users turning this on from the new Firefox Labs also affect the urgency?

I've attached an example:

I’m on page "Impostazioni avanzate" with "La modifica delle impostazioni avanzate di configurazione può compromettere le prestazioni e la sicurezza di Firefox." selected. Spiega i concetti chiave di questa selezione, usando parole semplici. Utilizza anche degli esempi.

Comment 1

[Donal Meehan [:dmeehan]]

Tracking as requested, though there still is the pending question if this is needed in Fx130.
Please note, this would need to land in central either way.

Comment 2

[Ed Lee :Mardak]

Attachment: Bug 1912080 - Chatbot prompt prefix string missing from localization r=tarek!

Allow prefix pref to be json with l10nId that allows localization.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6552ab5bfaa4
Chatbot prompt prefix string missing from localization r=tarek,fluent-reviewers,flod

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6552ab5bfaa4

Comment 5

[Ed Lee :Mardak]

Attachment: prompt prefix.png (it, ko, es-AR)

Comment 6

[Ed Lee :Mardak]

Attachment: Bug 1912080 - Chatbot prompt prefix string missing from localization

Allow prefix pref to be json with l10nId that allows localization.

Original Revision: https://phabricator.services.mozilla.com/D218804

Comment 7

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: beginning of chatbot prompts are in english
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: 1. install localized build or langpack, e.g., it 2. enable chatbot from labs with provider 3. select text and choose prompt and verify initial request is localized
• Risk associated with taking this patch: low
• Explanation of risk level: exposes the rest of the prompt to be localized similar to the rest
• String changes made/needed: yes: 1 fluent genai-prompt-prefix-selection
• Is Android affected?: no

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/26ad38097c04

Comment 9

[Rares Doghi, Desktop QA]

I will mark this issue Verified as fixed because it is in fact fixed for the languages mentioned in these comments (it, ko, es-AR), however it seems that for FR this issue still occurs. The context menu for the Fr build also shows English options to "Summarize, explain.."
Should this fix cover Fr and other languages as well ?

Comment 10

[Ed Lee :Mardak]

Looks like fr strings updated about 17 hours ago and beta strings were bumped 1 hour ago, so it should be in 130b5. autoland got bumped 3 hours ago, so next nightly 131 should have french too.

Comment 11

[Rares Doghi, Desktop QA]

French works great in our latest builds, Thank you !