1912095 - Text-Fragments: User activation does not work when opening a new tab on Android

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Jan Jaeschke [:jjaschke]]

The same issue as described in bug 1911339 also occurs on Firefox for Android. Since there's a fix for desktop already, this is a follow-up to fix the issue on Android.

Comment 1

[Edgar Chen [:edgar]]

Hi Makoto, do you know where GeckoView handles opening links in a new tab from the context menu? We may need to update the code to propagate user activation for text fragments to ensure it works on Android. Thank you!

Comment 2

[Makoto Kato [:m_kato]]

If from context menu, browser such as Fenix application will call GeckoSession.open and GeckoSession.load APIs when selecting menu.

I guess that we should add an parameter to GeckoSession.Loader and NavigationDelegate.LoadRequest.

Comment 3

[Makoto Kato [:m_kato]]

Attachment: Bug 1912095 - Part 1. Add an API to load Uri with text fragment actication. r=#geckoview-reviewers

Handle textDirectiveUserActivation for GeckoView (Bug 1888756).

When with referrer Gecko session, GeckoSession.load with text fragment
parameter won't scroll content even if URI has this parameter.

So I would like to add an API to set textDirectiveUserActivation for
external user activation such as context menu.

Comment 4

[Makoto Kato [:m_kato]]

Attachment: Bug 1912095 - Part 2. Set text directive flag when loading Url from context menu. r=#android-reviewers!

This is Fenix version of bug 1911339.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5885a6a60ecc
Part 1. Add an API to load Uri with text fragment actication. r=geckoview-reviewers,ohall,owlish

Comment 6

[amarc]

https://hg.mozilla.org/mozilla-central/rev/5885a6a60ecc

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/416a6701d255
Part 2. Set text directive flag when loading Url from context menu. r=android-reviewers,boek

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/416a6701d255