1912163 - [wpt-sync] Sync PR 47523 - [Selection API] Change getComposedRanges() from rest parameter to a dictionary

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 47523 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/47523
Details from upstream follow.

Di Zhang <[e-mail]> wrote:

[Selection API] Change getComposedRanges() from rest parameter to a dictionary

Per https://github.com/w3c/selection-api/issues/176, we should update
selection.getComposedRanges() from using a rest shadowRoots parameter
to using a dictionary that contains the array shadowRoots.

Change-Id: I6b5b3fed786cf6d75fa4a20c0b2a583635cd2aca
Bug: 40286116
Fixed: 355577223

Reviewed-on: https://chromium-review.googlesource.com/5770701
WPT-Export-Revision: 56feb5ec0195ff94f7294c7299dfe9311373d8e6

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 47523 applied with additional changes from upstream: 82f206603878dfa7dfa8c2a608e069c13767f90b

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4033f6cdc37be6fa7152844a46d3fba73737bb3

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 5 tests and 12 subtests

Status Summary

Firefox

OK : 5
PASS: 7
FAIL: 14

Chrome

OK : 5
PASS: 7
FAIL: 14

Safari

OK : 5
PASS: 7
FAIL: 14

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /dom/ranges/Range-isPointInRange-shadowdom.tentative.html [wpt.fyi]
  • isPointInRange() test for collapsed selection: FAIL (Chrome: FAIL, Safari: FAIL)
• /selection/shadow-dom/select-later-become-slotted-content.tentative.html [wpt.fyi]
  • test to select a light DOM element and it becomes a slotted content after the selection: FAIL (Chrome: FAIL, Safari: FAIL)
• /shadow-dom/selection-collapse-and-extend.tentative.html [wpt.fyi]
  • collapse can set selection to a node inside a shadow tree: FAIL (Chrome: FAIL, Safari: FAIL)
  • collapse abort steps when called with a disconnected node inside a shadow tree: FAIL (Chrome: FAIL, Safari: FAIL)
  • extend can set selection to a node inside a shadow tree: FAIL (Chrome: FAIL, Safari: FAIL)
  • extend abort steps when called with a disconnected node inside a shadow tree: FAIL (Chrome: FAIL, Safari: FAIL)
• /shadow-dom/selection-getComposedRanges-collapsed.tentative.html [wpt.fyi]
  • Setting the range to nodes that aren't in the same tree collapses both composed and non-composed ranges.: FAIL (Chrome: PASS, Safari: FAIL)
  • Setting the range to nodes in different shadow trees collapses ordinary ranges, but does not collapse composed ranges.: FAIL (Chrome: FAIL, Safari: FAIL)
• /shadow-dom/selection-getComposedRanges.tentative.html [wpt.fyi]
  • getComposedRanges should fail if argument is not a shadow root: FAIL (Chrome: FAIL, Safari: FAIL)
  • getComposedRanges returns a sequence with a static range pointing to a shadaw tree when there is a selection in the shadow tree and the shadow tree is specified as an argument: FAIL (Chrome: FAIL, Safari: FAIL)
  • getComposedRanges a sequence with a static range that crosses shadow boundaries when there is a forward selection that crosses shadow boundaries and the shadow tree is specified as an argument: FAIL (Chrome: FAIL, Safari: FAIL)
  • getComposedRanges returns a sequence with a static range pointing to the inner shadow tree when there is a selection in an inner shadow tree and the inner shadow tree is specified as an argument: FAIL (Chrome: FAIL, Safari: FAIL)
  • getComposedRanges returns a sequence with a static range pointing to the outer shadow tree when there is a selection in an inner shadow tree and the outer shadow tree is specified as an argument: FAIL (Chrome: FAIL, Safari: FAIL)
  • getComposedRanges returns a sequence with a static range without rescoping when there is a selection in an outer shadow tree and the inner shadow tree is specified as an argument: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee98c88acb67
[wpt PR 47523] - [Selection API] Change getComposedRanges() from rest parameter to a dictionary, a=testonly
https://hg.mozilla.org/integration/autoland/rev/bef6771fd273
[wpt PR 47523] - Update wpt metadata, a=testonly

Comment 5

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/ee98c88acb67
https://hg.mozilla.org/mozilla-central/rev/bef6771fd273