Closed
Bug 1912191
Opened 3 months ago
Closed 3 months ago
[toolbar redesign] crash report stops adjusting content height after onStop
Categories
(Fenix :: Toolbar, defect, P1)
Tracking
(firefox129 unaffected, firefox130 unaffected, firefox131 fixed)
RESOLVED
FIXED
131 Branch
Tracking | Status | |
---|---|---|
firefox129 | --- | unaffected |
firefox130 | --- | unaffected |
firefox131 | --- | fixed |
People
(Reporter: mavduevskiy, Assigned: mavduevskiy)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression)
Attachments
(2 files)
Steps to reproduce
- Set toolbar position to bottom
- Open about:crashreport page, rotate the device and note that the content of the crash page gets adjusted to toolbar hight while switching between horizontal and vertical mode.
- Lock the device.
- Unlock the device, and rotate it a few times again.
Expected behavior
The crash page content would be adjusted according to the toolbar hight
Actual behavior
There is extra space between the toolbar and the content of the page in the landscape mode
Device information
- Firefox version:
- Android device model:
- Android OS version:
Any additional information?
Assignee | ||
Updated•3 months ago
|
Assignee: nobody → mavduevskiy
Assignee | ||
Comment 1•3 months ago
|
||
the result of switching to landscape mode, when the onStop lifecycle method was called
Assignee | ||
Comment 2•3 months ago
|
||
if the orientation change happens after onStop call.
A scope can't be reused after it's cancelled, and another instance should be initialized to make the feature work within android lifecycle.
Updated•3 months ago
|
Attachment #9418253 -
Attachment description: WIP: Bug 1912191 - Fix content page not being adjusted on rotation → Bug 1912191 - Fix content page not being adjusted on rotation
Comment 3•3 months ago
|
||
Set release status flags based on info from the regressing bug 1910242
status-firefox129:
--- → unaffected
status-firefox130:
--- → unaffected
status-firefox131:
--- → affected
Updated•3 months ago
|
Attachment #9418253 -
Attachment description: Bug 1912191 - Fix content page not being adjusted on rotation → WIP: Bug 1912191 - Fix content page not being adjusted on rotation
Updated•3 months ago
|
Attachment #9418253 -
Attachment description: WIP: Bug 1912191 - Fix content page not being adjusted on rotation → Bug 1912191 - Fix content page not being adjusted on rotation
Pushed by mavduevskiy@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a828ef02353e
Fix content page not being adjusted on rotation r=android-reviewers,petru
Updated•3 months ago
|
Blocks: android-toolbar-phase-1-beta
Severity: -- → S3
Priority: -- → P1
Summary: [toolbar redesign] crash report stops adjusting content hight after onStop → [toolbar redesign] crash report stops adjusting content height after onStop
Comment 5•3 months ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 131 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•