Open Bug 1912283 Opened 3 months ago Updated 2 months ago

Handle records with the same id, but in different collections

Categories

(Application Services :: Suggest, defect, P3)

Product:
Application Services
Component:
Suggest
Type:
defect

Tracking

(Not tracked)

People

(Reporter: bdk, Unassigned)

Details

Our code currently assumes that record_id is unique, but now that we're processing both the quicksuggest and fakespot-suggest-products, that's no longer guaranteed.

As part of https://github.com/mozilla/application-services/pull/6334, I'm going to add a unit test for this with the failing parts commented out.

I believe the solution is to:

  • Track the collection in the suggestions table (maybe by numeric id rather than a string to keep the DB size down)
  • Update drop_suggestions to match against the collection as well.
Severity: -- → S3
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.