Open Bug 1912331 Opened 2 years ago Updated 5 months ago

Implement common password validation after obtaining decoded list

Categories

(Firefox :: Profile Backup, task, P3)

task

Tracking

()

People

(Reporter: kpatenio, Unassigned)

References

(Depends on 2 open bugs)

Details

(Whiteboard: [fidefe-device-migration])

Once we have downloaded a copy of the encoded list of common passwords, and after having decoded that list, we should dispatch events between the UI components and modules in the parent process (BackupService or another utils file) to actually validate the passwords inputted by users.

  • If found:
  • throw an error and update the password rules tooltip to display a warning icon for the common passwords rule
  • ensure that the confirmation button for the parent dialog containing the inputs remain disabled

If not found:

  • the password is considered valid, and a success icon for the common passwords rule is displayed in the tooltip
  • ensure that the confirmation button for the parent dialog containing the inputs are enabled, allowing users to move on to the next step

Other:

  • We should consider debouncing validation following an input event as well, perhaps by at least 300ms or 400ms
  • We may want to consider case sensitivity when comparing the user's inputted password vs. those found in the list. With the way fxa is currently implemented, it assumes that all words are lowercase. We should check if that assumption applies for us as well with a more updated list.
  • If downloads from Remote Settings aren't ready yet, we can temporarily resort to using a copy of fxa's encoded list to test the feature
Severity: -- → N/A
Priority: -- → P3
Whiteboard: [fidefe-device-migration]
Depends on: 1912327
Assignee: nobody → kpatenio
Status: NEW → ASSIGNED
Duplicate of this bug: 1901536
Status: ASSIGNED → NEW
Assignee: kpatenio → nobody
You need to log in before you can comment on or make changes to this bug.