1912354 - Allow DOMi to inspect any DOM element by shift + right click

Status: ASSIGNED

(SeaMonkey :: General, enhancement)

Description

[Matt A. Tobin [:nsITobin]]

One of the short-lived DOM Inspector forks had the ability to inspect any DOM Element, XUL or HTML, by holding shift and right clicking the element.

Previously, I added the ability to the UXP version of DOMi, this bug will port it to the original in a slightly more polished state.

Comment 1

[Matt A. Tobin [:nsITobin]]

Attachment: inspect-by-shift-right-click.patch

I have attempted to match general style and update things to the current scripting standard but I may have missed a few things.

Comment 2

[Matt A. Tobin [:nsITobin]]

Attachment: v2.patch

• Switched observerService to Services.obs.*.
• Further fixed code style and formatting

Comment 3

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9418614 [details] [diff] [review]
v2.patch

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: less functionality
Testing completed (on m-c, etc.): 2.53.20bb1 pre
Risk to taking this patch (and alternatives if risky): behind a pref so no risk
String changes made by this patch: none

Comment 4

[Ian Neal]

Comment on attachment 9418614 [details] [diff] [review]
v2.patch

[Triage Comment]
Seems to work okay from testing

Comments should end with a full stop:
// Shift + right click

Please fix indentation for:
Services.wm.addListener(this.aListener);

r/a=me with those fixed