1912455 - Clicking pause at 100% and then resume results in "Download failed"

Status: RESOLVED FIXED

(Firefox for Android :: Downloads, defect)

Description

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Attachment: Screen_recording_20240806_105522.mp4

Steps to reproduce

1. Start downloading a file (from this site for example)
2. Press pause when the download notification has reached 100% but "Download completed" has not shown yet.
   i. If the download notification does not hit 100% (i.e. it goes from x% to "Download completed" where x < 100), try downloading again.
3. Press resume
4. Observe that the notification shows "Download failed". However, if we go to the downloads directory, the download actually has not failed and can be successfully played.

Expected behavior

The notification should have said "Download completed".

Actual behavior

The notification says "Download failed".

Device information

• Firefox version: 130
• Android device model: Samsung A35
• Android OS version: Android 14

Comment 1

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Attachment: Screen_recording_20240806_104809.mp4

Comment 2

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Logcat stack trace:

ACTION_RESUME for 51e55713-f013-4fa9-9947-1ec7fa2b86a9
2024-08-06 10:41:39.352  1842-2322  DownloadMiddleware      org.mozilla.fenix.debug              D  Updated download BigBuckBunny(5).mp4 on the storage
2024-08-06 10:41:39.353  1842-7945  AbstractFe...oadService org.mozilla.fenix.debug              D  Starting download for 51e55713-f013-4fa9-9947-1ec7fa2b86a9 
2024-08-06 10:41:39.421  1842-7945  AbstractFe...oadService org.mozilla.fenix.debug              D  Fetching download for 51e55713-f013-4fa9-9947-1ec7fa2b86a9 
2024-08-06 10:41:39.424  1842-7945  AbstractFe...oadService org.mozilla.fenix.debug              D  Unable to fetching Download for 51e55713-f013-4fa9-9947-1ec7fa2b86a9 status FAILED
2024-08-06 10:41:39.425  1842-2322  DownloadMiddleware      org.mozilla.fenix.debug              D  Updated download BigBuckBunny(5).mp4 on the storage
2024-08-06 10:41:39.764  1842-1842  NotificationManager     org.mozilla.fenix.debug              I  org.mozilla.fenix.debug: notify(100, null, Notification(channel=mozac.... shortcut=null contentView=null vibrate=null sound=null defaults=0x0 flags=0x200 color=0xff592acb groupKey=mozac.feature.downloads.group vis=PRIVATE semFlags=0x0 semPriority=0 semMissedCount=0)) as user
2024-08-06 10:41:39.771  1842-1842  NotificationManager     org.mozilla.fenix.debug              I  org.mozilla.fenix.debug: notify(998369038, null, Notification(channel=mozac.... shortcut=null contentView=null vibrate=null sound=null defaults=0x0 flags=0x8 color=0xff592acb category=err groupKey=mozac.feature.downloads.group actions=2 vis=PRIVATE semFlags=0x0 semPriority=0 semMissedCount=0)) as user
2024-08-06 10:41:42.931 26397-26397 ViewRootIm...59368[App] org.mozilla.fenix                    I  onDisplayChanged oldDisplayState=2 newDisplayState=2
2024-08-06 10:41:42.931  1842-1842  ViewRootIm...e85b3[App] org.mozilla.fenix.debug              I  onDisplayChanged oldDisplayState=2 newDisplayState=2

Comment 3

[Iorga Gabriel]

Attachment: Bug 1912455 - Clicking pause at 100% and then resume should not result in "Download failed".

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4a2ce63fcbd
Clicking pause at 100% and then resume should not result in "Download failed". r=android-reviewers,npoon

Comment 5

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/e4a2ce63fcbd

Comment 6

[Delia Pop (Android QA)]

Verified as fixed in the latest Nightly 137.0a1 from 02/05 with Samsung GalaxyZ Fold 4 (Android 14). The download no longer fails after tapping the "Resume" button.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:giorga, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox136 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Attachment: Bug 1912455 - Don't make a client request when user clicks pause at 100% and then resume

This is done in a separate commit so it doesn't get uplifted

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5b8b77ae877
Don't make a client request when user clicks pause at 100% and then resume r=android-reviewers,rsainani

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/d5b8b77ae877

Comment 11

[Mira Lobontiu (Android QA)]

Verified as fixed on the latest Firefox for Android Nightly 140.0a1 with a Google Pixel 6 (Android 16), and a Xiaomi Mi8 Lite (Android 10).
Pausing a download at 100% and resuming displays the "Download complete" snackbar.