1912496 - Keep testing `media.eme.mfcdm.origin-filter.enabled`

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P1)

Description

[Alastor Wu [:alwu]]

We should keep testing the domain filter and ensure it won't break Hulu again.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1912496 - only block the MFCDM key system support if the MFCDM is enabled.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1912496 - part1 : do not let the MFCDM filter interefe non-MFCDM.

When calling requestMediaKeySystemAccess(), it can contain different
configs, and some of them can be hardware decryption. Having hardware
decryption configs doesn't mean we should ignore other configs
for the software decyption.

Therefore, moving the origin check into GetSupportedKeySystemConfigs()
in order to always generate software Widevine or ClearKey even if the
hardware decryption config exists.

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1912496 - part2 : only check the origin if the MFCDM playback is enabled.

Depends on D219161

Comment 4

[Alastor Wu [:alwu]]

Attachment: Bug 1912496 - part3 : add a test to ensure that Widevine L3 won't be broke by the origin check.

Depends on D219162

Comment 5

[Alastor Wu [:alwu]]

Attachment: Bug 1912496 - part4 : enable the pref on Nightly, Dev and Early Beta.

We would still like to keep testing this origin filter in those
versions for the preparation of enabling PlayReady on Netflix.

Depends on D219163

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20191d9ae7e2
part1 : do not let the MFCDM filter interefe non-MFCDM. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/83b25b05c5c2
part2 : only check the origin if the MFCDM playback is enabled. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/50f0c5945d4b
part3 : add a test to ensure that Widevine L3 won't be broke by the origin check. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/ce4fffb73aef
part4 : enable the pref on Nightly, Dev and Early Beta. r=media-playback-reviewers,padenot

Comment 7

[Iulian Moraru]

Backed out for causing non-unified build bustages on MediaKeySystemAccess.cpp.

• Push with failures

• Failure log

• Backout link

[task 2024-08-20T12:36:06.104Z] 12:36:06     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/dom/media/eme'
[task 2024-08-20T12:36:06.107Z] 12:36:06     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang-cl -fms-compatibility-version=19.39 -std:c++17 -Xclang -ivfsoverlay -Xclang /builds/worker/fetches/vs/overlay.yaml -FoMediaKeySystemAccess.obj -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -guard:cf -DNDEBUG=1 -DTRIMMED=1 -DUNICODE -D_UNICODE -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -D_SECURE_ATL -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DWIN32 -D_WIN32 -D_WINDOWS -DWIN32_LEAN_AND_MEAN -DWINAPI_NO_BUNDLED_LIBRARIES -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DMOZ_SUPPORT_LEAKCHECKING -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/dom/media/eme -I/builds/worker/workspace/obj-build/dom/media/eme -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -MD -DMOZILLA_CLIENT -FI /builds/worker/workspace/obj-build/mozilla-config.h -Zc:sizedDealloc- -Gy -Zc:inline -Gw -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -TP -GR- -D_HAS_EXCEPTIONS=0 -fcrash-diagnostics-dir=/builds/worker/artifacts -Z7 -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -Oy- -Werror -W3 -Wbitfield-enum-conversion -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtautological-constant-in-range-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wenum-compare-conditional -Wenum-float-conversion -Wvolatile -Wno-deprecated-anon-enum-enum-conversion -Wno-deprecated-enum-enum-conversion -Wno-deprecated-this-capture -Wcomma -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wno-error=atomic-alignment -Wno-error=deprecated-builtins -Wno-unknown-pragmas -Wno-ignored-pragmas -Wno-deprecated-declarations -Wno-microsoft-enum-value -Wno-microsoft-include -Wno-invalid-noreturn -Wno-inconsistent-missing-override -Wno-implicit-exception-spec-mismatch -Wno-microsoft-exception-spec -Wno-unused-local-typedef -Wno-ignored-attributes -Wno-used-but-marked-unused -Wno-psabi -Wthread-safety -Wno-error=builtin-macro-redefined -Wno-vla-cxx-extension -Wno-unknown-warning-option -fno-strict-aliasing -Xclang -ffp-contract=off  -Xclang -MP -Xclang -dependency-file -Xclang .deps/MediaKeySystemAccess.obj.pp -Xclang -MT -Xclang MediaKeySystemAccess.obj   /builds/worker/checkouts/gecko/dom/media/eme/MediaKeySystemAccess.cpp
[task 2024-08-20T12:36:06.108Z] 12:36:06    ERROR -  /builds/worker/checkouts/gecko/dom/media/eme/MediaKeySystemAccess.cpp(247,8): error: use of undeclared identifier 'IsMediaFoundationCDMPlaybackEnabled'
[task 2024-08-20T12:36:06.108Z] 12:36:06     INFO -    247 |       !IsMediaFoundationCDMPlaybackEnabled()) {
[task 2024-08-20T12:36:06.108Z] 12:36:06     INFO -        |        ^
[task 2024-08-20T12:36:06.108Z] 12:36:06     INFO -  1 error generated.
[task 2024-08-20T12:36:06.109Z] 12:36:06    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:674: MediaKeySystemAccess.obj] Error 1
[task 2024-08-20T12:36:06.109Z] 12:36:06     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/media/eme'
[task 2024-08-20T12:36:06.109Z] 12:36:06     INFO -  gmake[4]: Target 'target-objects' not remade because of errors.
[task 2024-08-20T12:36:06.109Z] 12:36:06    ERROR -  gmake[3]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:72: dom/media/eme/target-objects] Error 2
[task 2024-08-20T12:36:06.115Z] 12:36:06     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/dom/html'
[task 2024-08-20T12:36:06.116Z] 12:36:06     INFO -  dom/html/HTMLTableSectionElement.obj
[task 2024-08-20T12:36:06.116Z] 12:36:06     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/html'

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c55d22c0090d
part1 : do not let the MFCDM filter interefe non-MFCDM. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/eed76b0c695f
part2 : only check the origin if the MFCDM playback is enabled. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/3ed4953720ef
part3 : add a test to ensure that Widevine L3 won't be broke by the origin check. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/36e2308186b4
part4 : enable the pref on Nightly, Dev and Early Beta. r=media-playback-reviewers,padenot

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c55d22c0090d
https://hg.mozilla.org/mozilla-central/rev/eed76b0c695f
https://hg.mozilla.org/mozilla-central/rev/3ed4953720ef
https://hg.mozilla.org/mozilla-central/rev/36e2308186b4