1912564 - More shortcuts triggering and hiding improvements

Status: VERIFIED FIXED

(Core :: Machine Learning, enhancement)

Description

[Ed Lee :Mardak]

Various mousedown/up happen without changing the selection such as on menus or other inputs that can be ignored. Selection within inputs can be used too. Hiding when navigating away.

Comment 1

[Ed Lee :Mardak]

Rares noticed the shortcuts icon would briefly appear when clicking the page to deselect text. I believe it's because the deselection happens just briefly after mouseup, and that should be addressed by this bug detecting if the selection actually changed.

Comment 2

[Ed Lee :Mardak]

Attachment: Bug 1912564 - More shortcuts triggering and hiding improvements r=tarek!

Check for selection change instead of just having a selection. Support inputs/textarea selection. Hide before unload.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06351eb149c2
More shortcuts triggering and hiding improvements r=tarek

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/06351eb149c2

Comment 5

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly build 131.0a1 (2024-08-15)

Comment 6

[Rares Doghi, Desktop QA]

Updating the main status flag.