1912717 - Move LMinMax{D,F} codegen into shared CodeGenerator

Status: ASSIGNED

(Core :: JavaScript Engine: JIT, task, P1)

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1912717 - Part 1: Remove assertion to enable use for non-wasm callers. r=#spidermonkey-reviewers!

Drive-by change:
Use upper-case VIXL macro-assembler methods to match surrounding code.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1912717 - Part 2: Move LMinMaxD/F lowering to shared CodeGenerator. r=#spidermonkey-reviewers!

All implementations call into MacroAssembler::{min,max}{Double,Float}.

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1912717 - Part 3: Use 'canBeNaN' for minMaxDouble on ARM32. r=#spidermonkey-reviewers!

If canBeNaN is available, we might as well use it to improve codegen.

Also change some ma_b + ma_vmov sequences into conditional ma_vmov.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:anba, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.