Closed Bug 1912830 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 47574 - [calc-size] Allow applying calc-size to the auto min-size.

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
131 Branch
Tracking Flags:
Tracking Status
firefox131 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 47574 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/47574
Details from upstream follow.

Ian Kilpatrick <ikilpatrick@chromium.org> wrote:

[calc-size] Allow applying calc-size to the auto min-size.

This patch shifts where we apply the auto min-size. Previously we
change the blink::Length we resolved. This patch passes in an
auto_length to resolve if the original length has auto instead.

Fixes: block-aspect-ratio-038.html as we weren't correctly clamping
the auto-min-size by the max-size in the inline direction.

Bug: 1343829, 313072
Change-Id: Ia56ea5e52b3a42c5b7af8447eb19888883e7e76e
Reviewed-on: https://chromium-review.googlesource.com/5753047
WPT-Export-Revision: 8a523eaa5d3e814f1d42fc270a684e8d0a40c468

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

FAIL: 2

Chrome

FAIL: 2

Safari

FAIL: 2

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ecf7bc076831 [wpt PR 47574] - [calc-size] Allow applying calc-size to the auto min-size., a=testonly https://hg.mozilla.org/integration/autoland/rev/35f79b26098a [wpt PR 47574] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/ecf7bc076831
https://hg.mozilla.org/mozilla-central/rev/35f79b26098a

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox131: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 131 Branch
You need to log in before you can comment on or make changes to this bug.