Closed Bug 1912868 Opened 6 months ago Closed 6 months ago

Emit `property-updated-by-dragging` once the value was actually set

Categories

(DevTools :: Inspector: Rules, task)

task

Tracking

(firefox132 fixed)

RESOLVED FIXED
132 Branch
Tracking Status
firefox132 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The event is emitted before waiting for the value to be set
https://searchfox.org/mozilla-central/rev/02a4a649ed75ebaf3fbdf301c3d3137baf6842a1/devtools/client/inspector/rules/views/text-property-editor.js#1570-1571

this.prop.setValue(roundedValue + unit, this.prop.priority);
this.ruleView.emitForTests("property-updated-by-dragging");
Blocks: 1885232

This will help make browser_rules_edit-size-property-dragging.js more robust and
will help to land the changes from Bug 1885232.

Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/072e54d77eca [devtools] Emit `property-updated-by-dragging` once the value was actually set. r=devtools-reviewers,jdescottes.
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 132 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: