19130 - [IME][dogfood] ESC key will move caret to one line above before convert

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P3)

Description

[Teruko Kobayashi]

You can delete Japanese characters before commit by using ESC key.  In composer,
you can delete them, but the caret will move one line above.

Steps of reproduce
1. Open Composer
2. Turn on IME
3. Type Japanese characters (at this time, do not hit enter to commit)
4. Hit ESC key to delete whole characters

Notice that the characters were deleted, but the carret move to at the beginning
of the one above line.

Tested 111708 Win32 111612 Mac build.  Linux does not have this feature.

Comment 1

[Teruko Kobayashi]

I found that the big problem of this is following.
If you use ESC key to delete character before commit at the first line of
Composer, the caret is gone.  You cannot type any characters in Composer at all.
You have to quit Composer and start it again to type characters.

Comment 2

[Frank Tang]

Teruko and me find out this only happen when the IME text is in the beginning of
a text node (say in the beginning of a line). And the behavior is very similar
to 10683. When we hit ESC before IME commit we got empty text event
(which is right) and somehow our typing rule code or txn merge code
confused. Reassign this to buster and cc beppe and joe.

Comment 3

[Frank Tang]

*** Bug 19272 has been marked as a duplicate of this bug. ***

Comment 4

[rickg]

Please try to correct this bug.

Comment 5

[rubydoo123]

assigning to jfrancis

Comment 6

[Joe Francis]

i cant get to this one right now.  moving to 12/3

Comment 7

[Joe Francis]

This is fixed.  Your selection does not get confused and go upwards anymore.
Your selection does not get confused and prevent you from ever tyoping again
anymore, either.  But note that your caret still does disappear.  I believe this
is bug 20106 in action - I'm marking this fixed and adding comments to 20106 to
test this case.

Comment 8

[Teruko Kobayashi]

I tested this in 12-01-08 Win32 build under Winnt 4.0J.  The selection does not get confused and go upwards anymore.
However, the following problem still happnes.
If you use ESC key to delete character before commit at the first line of
Composer, the caret is gone.  You cannot type any characters in Composer at all.
You have to quit Composer and start it again to type characters.

I reopen this.

Comment 9

[leger]

Confirmed at pdt mtg.  Reopen good to stay on PDT+.

Comment 10

[Joe Francis]

i have the fix in hand for this.  Will check in after tree opens later today.

Comment 11

[Joe Francis]

fixed

Comment 12

[Teruko Kobayashi]

I verified this in 120608 Win32 and Mac build.

Comment 13

[Susie Wyshak]

*** Bug 162945 has been marked as a duplicate of this bug. ***