1913041 - [wpt-sync] Sync PR 47598 - [text-box-trim] Rename `text-box-edge` values

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 47598 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/47598
Details from upstream follow.

Koji Ishii <[e-mail]> wrote:

[text-box-trim] Rename text-box-edge values

This patch renames text-box-edge values from:

  text-box-edge: leading | \<text-edge>

to:

  text-box-edge: auto | \<text-edge>

Note the \<text-edge> definition is unchanged.

  \<text-edge> = [ text | cap | ex ] [ text | alphabetic ]?

as per the resolution at:
https://github.com/w3c/csswg-drafts/issues/10675#issuecomment-2274517610
and the new spec at:
https://drafts.csswg.org/css-inline-3/#propdef-text-box-edge

As per the new spec, the new auto value is identical to
text when the line-fit-edge property is initial.

The functionality the leading value provided is removed.

Bug: 358204934, 40254880
Change-Id: I738058cc79b5525b2cbb151b5765f65363b44e7f

Reviewed-on: https://chromium-review.googlesource.com/5776349
WPT-Export-Revision: 428eef2a4b79c77e488a9039c1921a0e34276993

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 47598 applied with additional changes from upstream: 2e6b59c7cb6c5ca476586f5f96840a170697c809

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=0e9a4267de7e756dd14a526d09219e05588d4511

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e2355f20ceab73cdadb076f445ab887dc49b3e0d

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 32 tests and 459 subtests

Status Summary

Firefox

OK : 10
PASS: 2295
FAIL: 58

Chrome

OK : 10
PASS: 2304
FAIL: 99

Safari

OK : 10
PASS: 2003
FAIL: 57

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

• /css/css-inline/text-box-trim/parsing/inheritance.html [wpt.fyi]
  • Property text-box-edge inherits: FAIL
  • Property text-box-trim has initial value none: FAIL
• /css/css-inline/text-box-trim/parsing/text-box-edge-computed.html [wpt.fyi]
  • Property text-box-edge value 'text': FAIL
  • Property text-box-edge value 'ex': FAIL
  • Property text-box-edge value 'cap': FAIL
  • Property text-box-edge value 'text alphabetic': FAIL
  • Property text-box-edge value 'text text': FAIL
  • Property text-box-edge value 'cap alphabetic': FAIL
  • Property text-box-edge value 'cap text': FAIL
  • Property text-box-edge value 'ex alphabetic': FAIL
  • Property text-box-edge value 'ex text': FAIL
• /css/css-inline/text-box-trim/parsing/text-box-edge-valid.html [wpt.fyi]
  • e.style['text-box-edge'] = "text" should set the property value: FAIL
  • e.style['text-box-edge'] = "ex" should set the property value: FAIL
  • e.style['text-box-edge'] = "cap" should set the property value: FAIL
  • e.style['text-box-edge'] = "text alphabetic" should set the property value: FAIL
  • e.style['text-box-edge'] = "cap alphabetic" should set the property value: FAIL
  • e.style['text-box-edge'] = "ex alphabetic" should set the property value: FAIL
• /web-animations/animation-model/animation-types/accumulation-per-property-002.html [wpt.fyi]
  • list-style: "outside url("http://localhost/test-2") square" onto "inside url("http://localhost/test-1") circle": FAIL
• /web-animations/animation-model/animation-types/addition-per-property-002.html [wpt.fyi]
  • list-style: "outside url("http://localhost/test-2") square" onto "inside url("http://localhost/test-1") circle": FAIL

New Tests That Don't Pass

• /css/css-inline/text-box-trim/text-box-trim-accumulation-001.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-inline/text-box-trim/text-box-trim-end-001.html?class=vlr,auto [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-inline/text-box-trim/text-box-trim-end-001.html?class=text [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-inline/text-box-trim/text-box-trim-end-001.html?class=vlr,ex [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-inline/text-box-trim/text-box-trim-end-001.html?class=vlr,text [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-inline/text-box-trim/text-box-trim-end-001.html?class=auto [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-inline/text-box-trim/text-box-trim-end-001.html?class=vrl,alphabetic [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-inline/text-box-trim/text-box-trim-end-001.html?class=vrl,auto [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-inline/text-box-trim/text-box-trim-end-001.html?class=vrl,text [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-inline/text-box-trim/text-box-trim-end-001.html?class=vlr,cap [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-inline/text-box-trim/text-box-trim-end-001.html?class=alphabetic [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-inline/text-box-trim/text-box-trim-start-001.html?class=auto [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-inline/text-box-trim/text-box-trim-start-001.html?class=ex [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-inline/text-box-trim/text-box-trim-start-001.html?class=vrl,ex [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-inline/text-box-trim/text-box-trim-start-001.html?class=vlr,auto [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-inline/text-box-trim/text-box-trim-start-001.html?class=vlr,text [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-inline/text-box-trim/text-box-trim-start-001.html?class=vrl,cap [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-inline/text-box-trim/text-box-trim-start-001.html?class=vrl,text [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-inline/text-box-trim/text-box-trim-start-001.html?class=cap [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-inline/text-box-trim/text-box-trim-start-001.html?class=text [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-inline/text-box-trim/text-box-trim-start-001.html?class=vlr,alphabetic [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-inline/text-box-trim/text-box-trim-start-001.html?class=vrl,auto [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-inline/text-box-trim/parsing/inheritance.html [wpt.fyi]
  • Property text-box-edge has initial value auto: FAIL (Chrome: FAIL, Safari: FAIL)
  • Property text-box-edge inherits: FAIL (Chrome: PASS, Safari: PASS)
  • Property text-box-trim has initial value none: FAIL (Chrome: PASS, Safari: PASS)
  • Property text-box-trim does not inherit: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-inline/text-box-trim/parsing/text-box-edge-computed.html [wpt.fyi]
  • Property text-box-edge value 'auto': FAIL (Chrome: FAIL, Safari: FAIL)
  • Property text-box-edge value 'text': FAIL (Chrome: PASS, Safari: PASS)
  • Property text-box-edge value 'ex': FAIL (Chrome: PASS, Safari: PASS)
  • Property text-box-edge value 'cap': FAIL (Chrome: PASS, Safari: PASS)
  • Property text-box-edge value 'text alphabetic': FAIL (Chrome: PASS, Safari: PASS)
  • Property text-box-edge value 'text text': FAIL (Chrome: PASS, Safari: PASS)
  • Property text-box-edge value 'cap alphabetic': FAIL (Chrome: PASS, Safari: PASS)
  • Property text-box-edge value 'cap text': FAIL (Chrome: PASS, Safari: PASS)
  • Property text-box-edge value 'ex alphabetic': FAIL (Chrome: PASS, Safari: PASS)
  • Property text-box-edge value 'ex text': FAIL (Chrome: PASS, Safari: PASS)
• /css/css-inline/text-box-trim/parsing/text-box-edge-valid.html [wpt.fyi]
  • e.style['text-box-edge'] = "auto" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
  • e.style['text-box-edge'] = "text" should set the property value: FAIL (Chrome: PASS, Safari: PASS)
  • e.style['text-box-edge'] = "ex" should set the property value: FAIL (Chrome: PASS, Safari: PASS)
  • e.style['text-box-edge'] = "cap" should set the property value: FAIL (Chrome: PASS, Safari: PASS)
  • e.style['text-box-edge'] = "text alphabetic" should set the property value: FAIL (Chrome: PASS, Safari: PASS)
  • e.style['text-box-edge'] = "text text" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
  • e.style['text-box-edge'] = "cap alphabetic" should set the property value: FAIL (Chrome: PASS, Safari: PASS)
  • e.style['text-box-edge'] = "cap text" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
  • e.style['text-box-edge'] = "ex alphabetic" should set the property value: FAIL (Chrome: PASS, Safari: PASS)
  • e.style['text-box-edge'] = "ex text" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
• /web-animations/animation-model/animation-types/accumulation-per-property-002.html [wpt.fyi]
  • list-style: "outside url("http://localhost/test-2") square" onto "inside url("http://localhost/test-1") circle": FAIL (Chrome: PASS, Safari: PASS)
  • text-decoration: "overline" onto "underline": FAIL (Chrome: FAIL)
  • text-decoration: "underline" onto "overline": FAIL (Chrome: FAIL)
• /web-animations/animation-model/animation-types/addition-per-property-002.html [wpt.fyi]
  • list-style: "outside url("http://localhost/test-2") square" onto "inside url("http://localhost/test-1") circle": FAIL (Chrome: PASS, Safari: PASS)
  • text-decoration: "overline" onto "underline": FAIL (Chrome: FAIL)
  • text-decoration: "underline" onto "overline": FAIL (Chrome: FAIL)
• /web-animations/animation-model/animation-types/interpolation-per-property-002.html [wpt.fyi]
  • list-style uses discrete animation when animating between "inside url("http://localhost/test-1") circle" and "outside url("http://localhost/test-2") square" with linear easing: FAIL (Chrome: FAIL, Safari: FAIL)
  • list-style uses discrete animation when animating between "inside url("http://localhost/test-1") circle" and "outside url("http://localhost/test-2") square" with effect easing: FAIL (Chrome: FAIL, Safari: FAIL)
  • list-style uses discrete animation when animating between "inside url("http://localhost/test-1") circle" and "outside url("http://localhost/test-2") square" with keyframe easing: FAIL (Chrome: FAIL, Safari: FAIL)
  • text-decoration uses discrete animation when animating between "underline" and "overline" with linear easing: FAIL (Chrome: FAIL)
  • text-decoration uses discrete animation when animating between "underline" and "overline" with effect easing: FAIL (Chrome: FAIL)
  • text-decoration uses discrete animation when animating between "underline" and "overline" with keyframe easing: FAIL (Chrome: FAIL)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6f222a47421
[wpt PR 47598] - [text-box-trim] Rename `text-box-edge` values, a=testonly
https://hg.mozilla.org/integration/autoland/rev/f0eb53bf61bf
[wpt PR 47598] - Update wpt metadata, a=testonly

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/a6f222a47421
https://hg.mozilla.org/mozilla-central/rev/f0eb53bf61bf