1913159 - 0.28 - 0.27% Base Content JS / Base Content JS (OSX, Windows) regression on Wed August 7 2024

Status: NEW

(Core :: JavaScript Engine, defect, P3)

Description

[Treeherder Bug Filer]

Perfherder has detected a awsy performance regression from push d775409d7c6abb76362a3430e9880ec032ad4679. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
0.28%	Base Content JS	macosx1015-64-shippable-qr	fission	1,509,024.00 -> 1,513,288.00
0.27%	Base Content JS	windows11-64-2009-shippable-qr	fission	1,514,036.67 -> 1,518,130.00

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 1687

For more information on performance sheriffing please see our FAQ.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1896390

Comment 2

[Dan Minor [:dminor]]

This adds the Iterator interface for iterator helpers to the JS global object, it's expected that the memory use would increase, as this adds a new feature.

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Should this be closed as WONTFIX then?

Comment 4

[Dan Minor [:dminor]]

Offhand, I think so. I don't think this is worth backing out iterator helpers for, but we could file a follow on bug to see if there's room to improve memory usage.

Comment 5

[Will Medina [:willyelm]]

Yes we can close this bug, we will open a low priority bug to review and improve the performance of it.