1913161 - Implement a max-age cap for cookies

Status: RESOLVED FIXED

(Core :: Networking: Cookies, enhancement, P2)

Description

[Andrea Marchesini [:baku]]

See: https://datatracker.ietf.org/doc/html/draft-ietf-httpbis-rfc6265bis#section-5.5

Comment 1

[Andrea Marchesini [:baku]]

Attachment: Bug 1913161 - Implement a max-age cap for cookies, r?edgul

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f89c9403564e
Implement a max-age cap for cookies, r=devtools-reviewers,cookie-reviewers,timhuang

Comment 3

[pstanciu]

Backed out for causing multiple failures.

• Backout link
• Push with failures
• Xpcshell Failure Log
• Push with failures
• Mochitest Failure Log

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8118def08de0
Implement a max-age cap for cookies, r=devtools-reviewers,cookie-reviewers,timhuang

Comment 5

[Atila Butkovits]

Backed out for causing xpcshell failures at test_bug1321912.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/a3f39c394a9d256c3f60265fbd8a83f178aa5189

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=8118def08de0d4c1fae0f4151586cef75b0c7c6e&selectedTaskRun=FxXm-iGgRoy-uQiKugerrw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=472071394&repo=autoland&lineNumber=3562

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ce372d2cff0
Implement a max-age cap for cookies, r=devtools-reviewers,cookie-reviewers,timhuang

Comment 7

[tszentpeteri]

Backed out for causing mochitest and wd failures related to cookies.

• Backout link
• Push with failures
• Failure Log for wd
• Failure Log for mochitest

[task 2024-08-28T18:11:04.113Z] 18:11:04     INFO - TEST-PASS | netwerk/cookie/test/mochitest/test_server_time.html | undefined assertion name 
[task 2024-08-28T18:11:04.113Z] 18:11:04     INFO - Buffered messages finished
[task 2024-08-28T18:11:04.113Z] 18:11:04     INFO - TEST-UNEXPECTED-FAIL | netwerk/cookie/test/mochitest/test_server_time.html | undefined assertion name - got "", expected "test2=foo"
[task 2024-08-28T18:11:04.113Z] 18:11:04     INFO - SimpleTest.is@https://example.org/tests/SimpleTest/SimpleTest.js:509:14
[task 2024-08-28T18:11:04.113Z] 18:11:04     INFO - testServerTime@https://example.org/tests/netwerk/cookie/test/mochitest/test_server_time.html?currentTestURL=netwerk%2Fcookie%2Ftest%2Fmochitest%2Ftest_server_time.html&closeWhenDone=1&showTestReport=false&expected=pass:55:7
[task 2024-08-28T18:11:04.113Z] 18:11:04     INFO - async*@https://example.org/tests/netwerk/cookie/test/mochitest/test_server_time.html?currentTestURL=netwerk%2Fcookie%2Ftest%2Fmochitest%2Ftest_server_time.html&closeWhenDone=1&showTestReport=false&expected=pass:69:1
[task 2024-08-28T18:11:04.113Z] 18:11:04     INFO - TEST-PASS | netwerk/cookie/test/mochitest/test_server_time.html | undefined assertion name 
[task 2024-08-28T18:11:04.113Z] 18:11:04     INFO - TEST-PASS | netwerk/cookie/test/mochitest/test_server_time.html | undefined assertion name 
[task 2024-08-28T18:11:04.113Z] 18:11:04     INFO - TEST-PASS | netwerk/cookie/test/mochitest/test_server_time.html | undefined assertion name 
[task 2024-08-28T18:11:04.113Z] 18:11:04     INFO - Not taking screenshot here: see the one that was previously logged
[task 2024-08-28T18:11:04.113Z] 18:11:04     INFO - TEST-UNEXPECTED-FAIL | netwerk/cookie/test/mochitest/test_server_time.html | undefined assertion name - got "", expected "test3=foo"
[task 2024-08-28T18:11:04.113Z] 18:11:04     INFO - SimpleTest.is@https://example.org/tests/SimpleTest/SimpleTest.js:509:14
[task 2024-08-28T18:11:04.113Z] 18:11:04     INFO - testServerTime@https://example.org/tests/netwerk/cookie/test/mochitest/test_server_time.html?currentTestURL=netwerk%2Fcookie%2Ftest%2Fmochitest%2Ftest_server_time.html&closeWhenDone=1&showTestReport=false&expected=pass:62:7
[task 2024-08-28T18:11:04.113Z] 18:11:04     INFO - async*@https://example.org/tests/netwerk/cookie/test/mochitest/test_server_time.html?currentTestURL=netwerk%2Fcookie%2Ftest%2Fmochitest%2Ftest_server_time.html&closeWhenDone=1&showTestReport=false&expected=pass:69:1
[task 2024-08-28T18:11:04.114Z] 18:11:04     INFO - GECKO(10143) | MEMORY STAT | vsize 2581MB | residentFast 136MB | heapAllocated 7MB
[task 2024-08-28T18:11:04.114Z] 18:11:04     INFO - GECKO(10143) | [Parent 10143, Main Thread] WARNING: IPC message 'PBrowser::Msg_WillChangeProcess' discarded: actor cannot send: file /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:557
[task 2024-08-28T18:11:04.114Z] 18:11:04     INFO - TEST-OK | netwerk/cookie/test/mochitest/test_server_time.html | took 868ms
[task 2024-08-28T18:11:04.163Z] 18:11:04     INFO - TEST-START | netwerk/cookie/test/mochitest/test_sharedWorker.html

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a6895f886e7
Implement a max-age cap for cookies, r=devtools-reviewers,cookie-reviewers,timhuang,webdriver-reviewers,Sasha

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/47919 for changes under testing/web-platform/tests

Comment 10

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/0a6895f886e7

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Is this worth calling out the Fx132 relnotes? Please nominate if so.

Comment 13

[Andrea Marchesini [:baku]]

No need to nominate it for Fx132