1913183 - Vendor in app-services c3774b262f27fabdd8ae7d064db5745029b347b9

Status: RESOLVED FIXED

(Application Services :: Suggest, enhancement)

Description

[Ben Dean-Kawamura [:bdk]]

This brings in the updated Fakespot matching logic and also fixes the deleted records issue.

Comment 1

[Ben Dean-Kawamura [:bdk]]

Attachment: Bug 1913183 - Vendor in app-services, r=nanj

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ef1531763cd
Vendor in app-services, r=nanj,supply-chain-reviewers

Comment 3

[Iulian Moraru]

Backed out for causing mass assertion failures on OwnedRustBuffer.cpp.

• Push with failures

• Failure log

• Backout link

[task 2024-08-15T12:59:04.084Z] 12:59:04     INFO - GECKO(3004) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to C:\Users\task_172372524917473\AppData\Local\Temp\tmp0vgzqscn.mozrunner\runtests_leaks_utility_pid8136.log
[task 2024-08-15T12:59:04.179Z] 12:59:04     INFO - GECKO(3004) | [ERROR error_support::handling] suggest-unexpected: Error from Remote Settings: Error parsing URL: relative URL with a cannot-be-a-base base
[task 2024-08-15T12:59:04.179Z] 12:59:04     INFO - GECKO(3004) | [6440] Assertion failure: IsValid(), at /builds/worker/checkouts/gecko/toolkit/components/uniffi-js/OwnedRustBuffer.cpp:15
[task 2024-08-15T12:59:04.180Z] 12:59:04     INFO - GECKO(3004) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to C:\Users\task_172372524917473\AppData\Local\Temp\tmp0vgzqscn.mozrunner\runtests_leaks_tab_pid8904.log
[task 2024-08-15T12:59:04.266Z] 12:59:04     INFO - GECKO(3004) | 1723726744256	Marionette	TRACE	Received observer notification browser-idle-startup-tasks-finished
[task 2024-08-15T12:59:04.271Z] 12:59:04     INFO - GECKO(3004) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to C:\Users\task_172372524917473\AppData\Local\Temp\tmp0vgzqscn.mozrunner\runtests_leaks_tab_pid5476.log
[task 2024-08-15T12:59:04.280Z] 12:59:04     INFO - GECKO(3004) | 1723726744276	RemoteAgent	TRACE	[11] ProgressListener Start: expectNavigation=false resolveWhenStarted=false unloadTimeout=40000 waitForExplicitStart=false
[task 2024-08-15T12:59:04.280Z] 12:59:04     INFO - GECKO(3004) | 1723726744276	RemoteAgent	TRACE	[11] ProgressListener Setting unload timer (40000ms)
[task 2024-08-15T12:59:04.280Z] 12:59:04     INFO - GECKO(3004) | 1723726744277	RemoteAgent	TRACE	[11] Wait for initial navigation: isInitial=false, isLoadingDocument=false
[task 2024-08-15T12:59:04.280Z] 12:59:04     INFO - GECKO(3004) | 1723726744277	RemoteAgent	TRACE	[11] Document already finished loading: about:blank
[task 2024-08-15T12:59:04.281Z] 12:59:04     INFO - GECKO(3004) | 1723726744277	RemoteAgent	TRACE	[11] ProgressListener Stop: has error=false url=about:blank
[task 2024-08-15T12:59:04.325Z] 12:59:04     INFO - GECKO(3004) | 1723726744321	Marionette	DEBUG	1 <- [1,1,null,{"sessionId":"89bdf913-5f26-4eed-ad2f-f103d2df8917","capabilities":{"acceptInsecureCerts":false,"browserName":"firefox","browserVersion":"131.0a1","platformName":"windows","unhandledPromptBehavior":"dismiss and notify","userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:131.0) Gecko/20100101 Firefox/131.0","moz:buildID":"20240815123646","moz:headless":false,"moz:platformVersion":"10.0","moz:processID":6440,"moz:profile":"C:\\Users\\task_172372524917473\\AppData\\Local\\Temp\\tmp0vgzqscn.mozrunner","moz:shutdownTimeout":60000,"pageLoadStrategy":"normal","timeouts":{"implicit":0,"pageLoad":300000,"script":30000},"setWindowRect":true,"strictFileInteractability":true,"moz:accessibilityChecks":false,"moz:webdriverClick":true,"moz:windowless":false,"proxy":{}}}]
[task 2024-08-15T12:59:04.370Z] 12:59:04     INFO - GECKO(3004) | 1723726744369	Marionette	DEBUG	1 -> [0,2,"Addon:Install",{"path":"C:\\Users\\task_172372524917473\\AppData\\Local\\Temp\\tmpltnf4s5n.zip","temporary":false}]
[task 2024-08-15T12:59:04.413Z] 12:59:04     INFO - GECKO(3004) | [Child 5476: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL a595c00 == 1 [pid = 5476] [id = 0]
[task 2024-08-15T12:59:04.414Z] 12:59:04     INFO - GECKO(3004) | [Child 5476: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 1 (b4321b0) [pid = 5476] [serial = 1] [outer = 0]
[task 2024-08-15T12:59:04.414Z] 12:59:04     INFO - GECKO(3004) | [Child 5476: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 2 (a596e00) [pid = 5476] [serial = 2] [outer = b4321b0]
[task 2024-08-15T12:59:04.450Z] 12:59:04     INFO - GECKO(3004) | [Child 5476: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 3 (b475a00) [pid = 5476] [serial = 3] [outer = b4321b0]
[task 2024-08-15T12:59:04.503Z] 12:59:04     INFO -  Initializing stack-fixing for the first stack frame, this may take a while...
[task 2024-08-15T12:59:05.110Z] 12:59:05     INFO - runtests.py | Waiting for browser...
[task 2024-08-15T12:59:25.930Z] 12:59:25     INFO - GECKO(3004) | #01: mozilla::uniffi::ScaffoldingCallHandlerUniFFIUniffiSuggestFnMethodSuggeststoreIngest::MakeRustCall() [toolkit/components/uniffi-js/UniFFIGeneratedScaffolding.cpp:800]
[task 2024-08-15T12:59:25.945Z] 12:59:25     INFO - GECKO(3004) | #02: mozilla::detail::RunnableFunction<`lambda at /builds/worker/checkouts/gecko/toolkit/components/uniffi-js/UniFFICall.cpp:60:11'>::Run() [xpcom/threads/nsThreadUtils.h:548]
[task 2024-08-15T12:59:25.946Z] 12:59:25     INFO - GECKO(3004) | #03: nsThreadPool::Run() [xpcom/threads/nsThreadPool.cpp:458]
[task 2024-08-15T12:59:25.946Z] 12:59:25     INFO - GECKO(3004) | #04: nsThread::ProcessNextEvent(bool, bool*) [xpcom/threads/nsThread.cpp:1199]
[task 2024-08-15T12:59:25.947Z] 12:59:25     INFO - GECKO(3004) | #05: NS_ProcessNextEvent(nsIThread*, bool) [xpcom/threads/nsThreadUtils.cpp:480]
[task 2024-08-15T12:59:25.947Z] 12:59:25     INFO - GECKO(3004) | #06: mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) [ipc/glue/MessagePump.cpp:299]
[task 2024-08-15T12:59:25.948Z] 12:59:25     INFO - GECKO(3004) | #07: MessageLoop::RunInternal() [ipc/chromium/src/base/message_loop.cc:370]
[task 2024-08-15T12:59:25.948Z] 12:59:25     INFO - GECKO(3004) | #08: MessageLoop::RunHandler() [ipc/chromium/src/base/message_loop.cc:364]
[task 2024-08-15T12:59:25.949Z] 12:59:25     INFO - GECKO(3004) | #09: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:346]
[task 2024-08-15T12:59:25.950Z] 12:59:25     INFO - GECKO(3004) | #10: nsThread::ThreadFunc(void*) [xpcom/threads/nsThread.cpp:372]
[task 2024-08-15T12:59:26.102Z] 12:59:26     INFO - GECKO(3004) | #11: _PR_NativeRunThread(void*) [nsprpub/pr/src/threads/combined/pruthr.c:399]
[task 2024-08-15T12:59:26.109Z] 12:59:26     INFO - GECKO(3004) | #12: pr_root(void*) [nsprpub/pr/src/md/windows/w95thred.c:139]
[task 2024-08-15T12:59:26.112Z] 12:59:26     INFO -  fix-stacks: error: failed to read debug info file `ucrtbase.pdb` for `C:\Windows\System32\ucrtbase.dll`
[task 2024-08-15T12:59:26.113Z] 12:59:26     INFO -  fix-stacks: note: this is expected and harmless for all PDB files on opt automation runs
[task 2024-08-15T12:59:26.113Z] 12:59:26     INFO -  fix-stacks: The system cannot find the file specified. (os error 2)
[task 2024-08-15T12:59:26.114Z] 12:59:26     INFO - GECKO(3004) | #13: time32 [C:\Windows\System32\ucrtbase.dll + 0x459e3]
[task 2024-08-15T12:59:26.117Z] 12:59:26     INFO -  fix-stacks: error: failed to read debug info file `wkernel32.pdb` for `C:\Windows\System32\KERNEL32.DLL`
[task 2024-08-15T12:59:26.117Z] 12:59:26     INFO -  fix-stacks: note: this is expected and harmless for all PDB files on opt automation runs
[task 2024-08-15T12:59:26.117Z] 12:59:26     INFO -  fix-stacks: The system cannot find the file specified. (os error 2)
[task 2024-08-15T12:59:26.118Z] 12:59:26     INFO - GECKO(3004) | #14: BaseThreadInitThunk [C:\Windows\System32\KERNEL32.DLL + 0x17ba9]
[task 2024-08-15T12:59:26.195Z] 12:59:26     INFO - GECKO(3004) | #15: mozilla::interceptor::WindowsDllInterceptor<mozilla::interceptor::VMSharingPolicyShared>::Init<10>(const char[10]&) [toolkit/xre/dllservices/mozglue/nsWindowsDllInterceptor.h:335]
[task 2024-08-15T12:59:26.211Z] 12:59:26     INFO -  fix-stacks: error: failed to read debug info file `wntdll.pdb` for `C:\Windows\SYSTEM32\ntdll.dll`
[task 2024-08-15T12:59:26.212Z] 12:59:26     INFO -  fix-stacks: note: this is expected and harmless for all PDB files on opt automation runs
[task 2024-08-15T12:59:26.213Z] 12:59:26     INFO -  fix-stacks: The system cannot find the file specified. (os error 2)
[task 2024-08-15T12:59:26.213Z] 12:59:26     INFO - GECKO(3004) | #16: RtlInitializeExceptionChain [C:\Windows\SYSTEM32\ntdll.dll + 0x6c10b]
[task 2024-08-15T12:59:26.214Z] 12:59:26     INFO - GECKO(3004) | #17: RtlClearBits [C:\Windows\SYSTEM32\ntdll.dll + 0x6c08f]
[task 2024-08-15T12:59:26.215Z] 12:59:26     INFO - GECKO(3004) | [Utility 8136, IPC I/O Child] WARNING: [D662201E71C04094.D72AE78688757FC6]: Dropping message '<null>'; no connection to unknown peer 1.1: file /builds/worker/checkouts/gecko/ipc/glue/NodeController.cpp:364
[task 2024-08-15T12:59:26.216Z] 12:59:26     INFO - GECKO(3004) | [Utility 8136, Main Thread] WARNING: Shutting down Utility process early due to a crash!: file /builds/worker/checkouts/gecko/ipc/glue/UtilityProcessChild.cpp:358
[task 2024-08-15T12:59:26.216Z] 12:59:26     INFO - TEST-INFO | Main app process: exit 1
[task 2024-08-15T12:59:26.216Z] 12:59:26    ERROR - TEST-UNEXPECTED-FAIL | ShutdownLeaks | process() called before end of test suite
[task 2024-08-15T12:59:26.217Z] 12:59:26     INFO - TEST-INFO | Confirming we saw 14 DOCSHELL created and 1 destroyed log strings.
[task 2024-08-15T12:59:26.217Z] 12:59:26     INFO - TEST-INFO | Confirming we saw 39 DOMWINDOW created and 3 destroyed log strings.
[task 2024-08-15T12:59:26.218Z] 12:59:26     INFO - Buffered messages finished
[task 2024-08-15T12:59:26.218Z] 12:59:26     INFO - runtests.py | Application ran for: 0:00:29.902337

Comment 4

[Ben Dean-Kawamura [:bdk]]

Looks like the upstream changes have revealed an issue in the uniffi-bindgen-gecko-js code. If a scaffolding function returns a RustBuffer and it fails, this MOZ_ASSERT(IsValid()) line fails.

I'm just going to remove that assert, since it doesn't seem correct to me anymore. This case seems like a valid reason to create an empty RustBuffe and there was also a related case recently: on successful calls, the scaffolding code returns an empty error_buf field. The alternative would be to always check that the low-level RustBuffer is non-empty before creating a OwnedRustBuffer from it, but that seems worse to me. In addition having to write extra checks, that solution risks leaking rust buffers because of incorrect checks. I can't see any downside to simply supporting creating an empty OwnedRustBuffer from an empty RustBuffer.

Comment 5

[Ben Dean-Kawamura [:bdk]]

Looks like that worked. My try build before the changes was getting tons of errors. My try build after the changes was green.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c48afa57d242
Vendor in app-services, r=nanj,supply-chain-reviewers

Comment 7

[Atila Butkovits]

Backed out for causing failures at test_quicksuggest_fakespot.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/4a4154c1b22d2896431de7fc63eeadcd6a68d7c1

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=c48afa57d24249c7d6f3b7adf702f3ebd0e348cc

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=470565134&repo=autoland&lineNumber=2314
https://treeherder.mozilla.org/logviewer?job_id=470565144&repo=autoland&lineNumber=6268

Comment 8

[Ben Dean-Kawamura [:bdk]]

These are coming from the changes in the expected RS schema. I'm going to merge in :adw's changes that fix these

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f3ebe8600c8
Vendor in app-services, r=nanj,supply-chain-reviewers,urlbar-reviewers,adw

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/6f3ebe8600c8