1913193 - Dedicated Search button gets stuck after clicking it twice

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Petruta Horea [:phorea]]

Found in

• Nightly 131.0a1;

Affected versions

• Nightly 131.0a1;

Affected platforms

• Windows 11;

Preconditions

• Have browser.urlbar.scotchBonnet.enableOverride to TRUE

Steps to reproduce

1. From a new tab, open the unified desktop search button dropdown by clicking on it (down arrow)
2. Close the dropdown by clicking on the button again
3. Repeat the above steps (if necessary)

Expected result

• The dropdown is correctly closed and reopened.

Actual result

• The dedicated search button is stuck in the address bar, it can’t be reopened. Address bar dropdown is not opened when starting to type into urlbar. This persists in new tabs, but not in new windows.
• Browser Console warning: SearchEngine: getSubmission: searchTerms is empty! 2 SearchEngine.sys.mjs:1428:23

Regression range

• Not a regression.

Additional notes

• Closing the dropdown by clicking outside of it or by pressing Escape will not reproduce this issue.

Comment 1

[Dale Harvey (:daleharvey)]

I have seen a few people mention this but have not been able to reproduce, is it an OS specific bug?

Comment 2

[Petruta Horea [:phorea]]

(In reply to Dale Harvey (:daleharvey) from comment #1)

I have seen a few people mention this but have not been able to reproduce, is it an OS specific bug?

On latest Nightly we could only reproduce this on Win 10 and Win 11.

Comment 3

[Dale Harvey (:daleharvey)]

Attachment: WIP: Bug 1913193 - Prevent dedicated search button from getting stuck.

Comment 4

[Dale Harvey (:daleharvey)]

Attachment: Bug 1913193 - Ensure dedicated search button does not get stuck. r=daisuke

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c9c7c3b8bb9
Ensure dedicated search button does not get stuck. r=daisuke,urlbar-reviewers

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/5c9c7c3b8bb9

Comment 7

[BugBot [:suhaib / :marco]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 8

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-08-14 Nightly build on Windows 10.
Verified as fixed on Firefox Nightly 133.0a1 on Windows 10, macOS 14, Ubuntu 22.