1913204 - New Switch to tab button does not distinguish between container and regular tabs

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Petruta Horea [:phorea], Desktop Test Engineering (back on Sep 5th)]

Attachment: missing container label

Found in

• Nightly 131.0a1;

Affected versions

• Nightly 131.0a1;

Affected platforms

• Ubuntu 22;
• macOS 14;
• Windows 11;

Preconditions

• Have browser.urlbar.scotchBonnet.enableOverride to TRUE

Steps to reproduce

1. Launch Firefox and open a website in a container tab, eg. Personal
2. Open a new tab.
3. Focus the adressbar.
4. Write the first letters from the tab opened in step 1. or select Tabs button
5. Observe the Switch to Tab button.

Expected result

• Switch to tab button shows the container label.

Actual result

• Switch to tab button doesn’t show the container label.

Regression range

• Not a regression.

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1913204: Apply container color border to secondary action button for tab switch

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b7a22b47b05
Apply container color border to secondary action button for tab switch r=desktop-theme-reviewers,urlbar-reviewers,daleharvey,dao

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/5b7a22b47b05

Comment 4

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-08-14 Nightly build on Windows 10.
Verified as fixed on Firefox Nightly 132.0a1 on Windows 10, Ubuntu 22, macOS 14.
The fix displays the container tags, however, they are written in lowercase lettering. Pre-Scotch Bonnet behaviour used uppercase lettering.
I’ve logged bug 1918622 for the lowercase lettering scenario mentioned above.