1913263 - Developer tools: Inspector picker plays/pauses video

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[TripleCamera]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:129.0) Gecko/20100101 Firefox/129.0

Steps to reproduce:

• Open https://developer.mozilla.org/fr/docs/Web/HTML/Element/Video
• Open the inspector
• With the element picker, try to select the <video> element in the demo area

Actual results:

When the <video> element is selected, the video plays (or pauses if it is already playing) at the same time.

Expected results:

When the <video> element is selected, the video should not play (or pause) at the same time.

Comment 1

[TripleCamera]

This is originally reported at bug 1596742.

Comment 2

[Julian Descottes [:jdescottes]]

Check if this is related to Bug 1651033, and pointer events.

Comment 3

[Julian Descottes [:jdescottes]]

Not the same issue as Bug 1651033.
In this case the videocontrols use mozSystemGroup events which we are not preventing at the moment.

https://searchfox.org/mozilla-central/rev/e942f7bc56cd103bba86b396ddeba5b1ab04f1a4/toolkit/content/widgets/videocontrols.js#2570-2579

// Use the handleEvent() callback for all media events.
// Only the "error" event listener must capture, so that it can trap error
// events from <source> children, which don't bubble. But we use capture
// for all events in order to simplify the event listener add/remove.
for (let event of this.videoEvents) {
  this.video.addEventListener(event, this, {
    capture: true,
    mozSystemGroup: true,
  });
}

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1913263 - [devtools] Also prevent mozSystemGroup events while using the node picker

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1913263 - [devtools] Handle generic keydown events in nodePicker even if no currentNode available

Depends on D219804

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99b8e850f25c
[devtools] Also prevent mozSystemGroup events while using the node picker r=devtools-reviewers,ochameau
https://hg.mozilla.org/integration/autoland/rev/71c133d064f7
[devtools] Handle generic keydown events in nodePicker even if no currentNode available r=devtools-reviewers,ochameau

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/99b8e850f25c
https://hg.mozilla.org/mozilla-central/rev/71c133d064f7