1913282 - Use nsIFaviconService::setFaviconForPage() for favicon feed

Status: RESOLVED FIXED

(Toolkit :: Places, task)

Description

[Daisuke Akatsuka (:daisuke)]

Use nsIFaviconService::setFaviconForPage() instead of setAndFetchFaviconForPage() for favicon feed.
Also, we might need to consider stopping fetching favicon data from network.

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1913282: Use nsIFaviconService::setFaviconForPage() for favicon feed

Depends on D218736

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4baeb63e913c
Use nsIFaviconService::setFaviconForPage() for favicon feed r=home-newtab-reviewers,mak,nbarrett

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/4baeb63e913c

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/8a302cd72f67
Backed out changeset 4baeb63e913c for frequent crashes. a=backout DONTBUILD

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

There are 98 crashes from 17 installs of the latest Firefox 132.0a1 build, e.g. bp-f064d5e7-d082-454a-bbf3-4674d0240930.
New Nightlies with the change backed out will be requested.

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out from beta: https://hg.mozilla.org/releases/mozilla-beta/rev/4c8e2a3293eecdd4b945260243f05834e09aaf5f

Comment 7

[Jan Varga [:janv]]

The crash happens immediately after my tabs are restored. I had to install an older version of Nightly manually.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98ae74f28168
Use nsIFaviconService::setFaviconForPage() for favicon feed r=home-newtab-reviewers,mak,nbarrett

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/98ae74f28168