1913339 - Implement default-policy support for `Element.innerHTML` and `Element.insertAdjacentHTML`

Status: RESOLVED FIXED

(Core :: DOM: Security, task, P3)

Comment 1

[Mirko Brodesser (:mbrodesser-Igalia), offline until 10th of Feb]

Attachment: Bug 1913339: part 1) Simplify existing WPT for the default-policy support of `Element.insertAdjacentHTML`. r=smaug

The additional parameter is not required.

Comment 2

[Mirko Brodesser (:mbrodesser-Igalia), offline until 10th of Feb]

Attachment: Bug 1913339: part 4) Implement default-policy support for `Element.innerHTML` and `Element.insertAdjacentHTML`. r=smaug!,peterv!

Depends on D219255

Comment 3

[Mirko Brodesser (:mbrodesser-Igalia), offline until 10th of Feb]

Attachment: Bug 1913339: part 2) Support default policies in `TrustedTypePolicyFactory`. r=peterv,smaug

The remaining support for default policies will be added in other
patches.

Depends on D219255

Comment 4

[Mirko Brodesser (:mbrodesser-Igalia), offline until 10th of Feb]

Attachment: Bug 1913339: part 3) Make some sub-tests of <block-string-assignment-to-Element-insertAdjacentHTML.html> less dependent on each other. r=smaug

Allows to let them pass on Gecko too, given a Gecko-specific bug (see
the test). The text-to-HTML transformation, which is what the test is
supposed to test, is still tested.

Comment 5

[Mirko Brodesser (:mbrodesser-Igalia), offline until 10th of Feb]

Attachment: Bug 1913339: part 5) Annotate `NonVoidLatin1StringToJsval` and `NonVoidStringToJsval` as `[[nodiscard]]`. r=jandem

In most (all?) cases the failure case needs to be handled.

Comment 6

[Mirko Brodesser (:mbrodesser-Igalia), offline until 10th of Feb]

Edit: moving comment to other ticket.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4d0ee017f1e
part 1) Simplify existing WPT for the default-policy support of `Element.insertAdjacentHTML`. r=smaug
https://hg.mozilla.org/integration/autoland/rev/8d3265a67df7
part 2) Support default policies in `TrustedTypePolicyFactory`. r=peterv,smaug
https://hg.mozilla.org/integration/autoland/rev/b741269269ef
part 3) Make some sub-tests of <block-string-assignment-to-Element-insertAdjacentHTML.html> less dependent on each other. r=smaug
https://hg.mozilla.org/integration/autoland/rev/8f8c6c4a4ab8
part 4) Implement default-policy support for `Element.innerHTML` and `Element.insertAdjacentHTML`. r=peterv,smaug,sessionstore-reviewers,sclements

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/48646 for changes under testing/web-platform/tests

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e4d0ee017f1e
https://hg.mozilla.org/mozilla-central/rev/8d3265a67df7
https://hg.mozilla.org/mozilla-central/rev/b741269269ef
https://hg.mozilla.org/mozilla-central/rev/8f8c6c4a4ab8

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 12

[Mirko Brodesser (:mbrodesser-Igalia), offline until 10th of Feb]

Reopening for the last (minor) patch to land.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b280c543c450
part 5) Annotate `NonVoidLatin1StringToJsval` and `NonVoidStringToJsval` as `[[nodiscard]]`. r=jandem

Comment 14

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b280c543c450