1913363 - Disable metric service

Status: VERIFIED FIXED

(Fenix :: Experimentation and Telemetry, enhancement)

Description

[Zac McKenney [:zmckenney]]

Disable metric service in Fenix and remove toggle switch for associated preference.

Comment 1

[Zac McKenney [:zmckenney]]

Attachment: Bug 1913363 - Remove metric service and associated preference toggle switch.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa3f39b0466b
Remove metric service and associated preference toggle switch. r=android-reviewers,amejiamarmol,twhite

Comment 3

[Atila Butkovits]

Backed out for causing linting failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/f5ef3ccd2d9e72e833b6d6f814a6c47cbeb460b3

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=fa3f39b0466b74cb99bac3d651549f996b635404

Failure log: https://treeherder.mozilla.org/logviewer?job_id=470577728&repo=autoland&lineNumber=349

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6af9794f842e
Remove metric service and associated preference toggle switch. r=android-reviewers,amejiamarmol,twhite

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/6af9794f842e

Comment 6

[Aaron Train [:aaronmt]]

Hello, is this expected to remove "Marketing Data" in the Data Collection area?

If so, this needs test needs to be updated

https://searchfox.org/mozilla-central/source/mobile/android/fenix/app/src/androidTest/java/org/mozilla/fenix/ui/SettingsPrivacyTest.kt#57
and the robot to remove the verification check https://searchfox.org/mozilla-central/source/mobile/android/fenix/app/src/androidTest/java/org/mozilla/fenix/ui/robots/SettingsSubMenuDataCollectionRobot.kt#52

Comment 7

[Donal Meehan [:dmeehan]]

:zmckenney could you please add a beta and release uplift request on this when ready?
The timing is tight to make the planned Fx129 dot release build on Monday 2024-08-19

Comment 8

[Delia Pop]

Attachment: Nightly131.jpg

Verified as fixed in the latest Nightly 131.0a1 from 08/19 with Google Pixel 8 Pro (Android 14). The "Marketing data" toggle was remove from Data collection.

Comment 9

[twhite]

Comment on attachment 9419298 [details]
Bug 1913363 - Remove metric service and associated preference toggle switch.

Beta/Release Uplift Approval Request

• User impact if declined: Toggle switch behaviour won't be updated
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Same as Nightly
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Verified in Nightly
• String changes made/needed:
• Is Android affected?: No

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9419298 [details]
Bug 1913363 - Remove metric service and associated preference toggle switch.

Approved for 130.0b8 and 129.0.2.

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/c6f0209c7923

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Note for QA, this was uplifted to Beta for 130.0b8. It didn't land in time for b7.

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/5ea285f28c5b

Comment 14

[Vasilica Tamas]

Attachment: 129.0.2RC.jpg

This issue was verified as fixed on Firefox 129.0.2 using a Google pixel 8 with Android 14 and OnePlus 6T with Android 11. "Marketing data" toggle is no longer displayed in Data collection.

Comment 15

[Delia Pop]

Attachment: 1724313049739.JPEG

Verified as fixed in Beta 130.0b8 with Samsung Tab S8 Ultra 5G (Android 14) . The "Marketing data" toggle was remove from Data collection.