Closed Bug 1913374 Opened 3 months ago Closed 3 months ago

[wpt-sync] Sync PR 47624 - [layout] Consider the aspect-ratio for flex's auto-min size.

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
131 Branch
Tracking Flags:
Tracking Status
firefox131 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 47624 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/47624
Details from upstream follow.

Ian Kilpatrick <ikilpatrick@chromium.org> wrote:

[layout] Consider the aspect-ratio for flex's auto-min size.

Previously we only used the "min-intrinsic" size, this left web
developers confused as to why the aspect-ratio was dropped.

This patch changes the content-size suggestion to:

  • First look at the content-size (which will include aspect-ratio
    if applicable).
  • Then if the have an aspect ratio, also consider the min-intrinsic
    size (which doesn't include the aspect-ratio directly, but does
    consider the transferred sizes).

Fixed: 342186350
Change-Id: Ifadbc037dd07d3d328bdf3374e97bf925e9b7cec

Reviewed-on: https://chromium-review.googlesource.com/5786821
WPT-Export-Revision: d6fcaa895ebc119dfca0cd513a45f912d1b7e3d8

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 10 tests

Status Summary

Firefox

PASS: 8
FAIL: 2

Chrome

PASS: 4
FAIL: 6

Safari

PASS: 6
FAIL: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2f17beb27c52 [wpt PR 47624] - [layout] Consider the aspect-ratio for flex's auto-min size., a=testonly https://hg.mozilla.org/integration/autoland/rev/1cfc1fdbe37f [wpt PR 47624] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/2f17beb27c52
https://hg.mozilla.org/mozilla-central/rev/1cfc1fdbe37f

Status: NEW → RESOLVED
Closed: 3 months ago
status-firefox131: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 131 Branch
You need to log in before you can comment on or make changes to this bug.