1913422 - Jonathan Olson's "Exact Polygonal Filtering" encounters WebGPU shader errors

Status: NEW

(Core :: Graphics: WebGPU, defect)

Comment 1

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Screenshot 2024-08-16 at 9.18.13 AM.png

Comment 2

[Erich Gubler [:ErichDonGubler] (he/him)]

Console errors for shader compilation:

WebGPU compilation info for shader module "module_ tile" (1 error(s), 0 warning(s), 0 info)

Shader validation error: 
    ┌─ module_ tile:192:20
    │
192 │         let edge = result.edges[ i ];
    │                    ^^^^^^^^^^^^^^^^^ naga::Expression [120]

WebGPU compilation info for shader module "module_ two pass coarse" (1 error(s), 0 warning(s), 0 info)

Shader validation error: 
    ┌─ module_ two pass coarse:205:20
    │
205 │         let edge = result.edges[ i ];
    │                    ^^^^^^^^^^^^^^^^^ naga::Expression [154]

Comment 3

[Jeff Muizelaar [:jrmuizel]]

After the fix to bug 1913424, I get this error now:

Shader validation error: 
     ┌─ module_ two pass fine:992:1
     │  
 992 │ ╭ fn evaluate_render_program_instructions(
 993 │ │   render_program_index: u32,
 994 │ │   centroid: vec2f,
 995 │ │   bounds_centroid: vec2f
     · │
1271 │ │           stack_length += 2;
     │ │           ^^^^^^^^^^^^^^^^^ naga::Expression [741]
     · │
1407 │ │   }
1408 │ │   return stack[ 0u ];
     │ ╰─────────────────────^ naga::Function [31]

Comment 4

[Erich Gubler [:ErichDonGubler] (he/him)]

The issue :jrmuizel mentions in comment 3 is bug 1829879.

Comment 5

[Tom S. (please needinfo tschuster)]

This demo just crashed Firefox: https://crash-stats.mozilla.org/report/index/c78e2805-e0c9-46c1-84d2-a28930250226

Comment 6

[Erich Gubler [:ErichDonGubler] (he/him)]

Tom: Unfortunately that stack doesn't help very much! 😅 All the interesting bits are marked as libxul.so (deleted).

Can't reproduce on my M1 MacBook Pro; perhaps the crash is Linux- or even distro-specific?

Comment 7

[Tom S. (please needinfo tschuster)]

(In reply to Erich Gubler [:ErichDonGubler] from comment #6)

Tom: Unfortunately that stack doesn't help very much! 😅 All the interesting bits are marked as libxul.so (deleted).

Very strange indeed. I am using the official mozilla-deb. A manually downloaded build produces a better crash report.

Comment 8

[Andy Leiserson [:aleiserson]]

The crash is in the SPIR-V backend, so it will be Linux-only (or at least, not Mac/Windows). I noted it here, which is linking to a bunch of issues with the same signature (the nature of this issue is such that it's hard to know how many unique underlying causes there could be).

Loading the page on my Mac, I do not immediately see any errors that look like bug 1829879 (or that even look WebGPU-related at all) in the console. But there do appear to be a few suspiciously blank spots on the page.

I only scrolled through the page, didn't read it, so don't know everywhere that something should be rendered. I tried it in Chrome, and the blur demo near the bottom of the page worked briefly, then went blank and the console started spewing errors. I wasn't able to catch the blur demo doing anything at all in Firefox.