Closed Bug 1913478 Opened 2 months ago Closed 2 months ago

Perma TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_UrlbarInput_<...>.js | Check the scheme box visibility - "hidden" == "visible" | Search string should be the urlbar value. | when Gecko 131 merges to beta on 2024-09-02

Categories

(Firefox :: Address Bar, defect)

Product:
Firefox
Component:
Address Bar
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
131 Branch
Tracking Flags:
Tracking Status
firefox-esr115 --- unaffected
firefox-esr128 --- unaffected
firefox129 --- unaffected
firefox130 --- unaffected
firefox131 + verified

People

(Reporter: smolnar, Assigned: jteow)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Bug 1913478 - Fix CSS of urlbar-input in overflow states - r?dao!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1913478 - Ensure the Persisted Search Terms pref is enabled in the Unified Search Button test - r?adw!
48 bytes, text/x-phabricator-request
Details | Review

Central as beta simulation

How to run these simulations

Failure log

also, there's additional failure lines on late beta simulation

Failure log Late-Beta

TEST-PASS | browser/components/urlbar/tests/browser/browser_UrlbarInput_overflow.js | Check the overflow side - "left" == "left" - 
[task 2024-08-16T12:48:20.760Z] 12:48:20     INFO - Buffered messages finished
[task 2024-08-16T12:48:20.761Z] 12:48:20     INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_UrlbarInput_overflow.js | Check the scheme box visibility - "hidden" == "visible" - 
[task 2024-08-16T12:48:20.761Z] 12:48:20     INFO - Stack trace:
[task 2024-08-16T12:48:20.761Z] 12:48:20     INFO - chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_UrlbarInput_overflow.js:testVal:76
[task 2024-08-16T12:48:20.761Z] 12:48:20     INFO - chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_UrlbarInput_overflow.js:null:122
[task 2024-08-16T12:48:20.761Z] 12:48:20     INFO - chrome://mochikit/content/browser-test.js:handleTask:1145
[task 2024-08-16T12:48:20.762Z] 12:48:20     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1217
[task 2024-08-16T12:48:20.762Z] 12:48:20     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1358
[task 2024-08-16T12:48:20.762Z] 12:48:20     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1134
[task 2024-08-16T12:48:20.762Z] 12:48:20     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2024-08-16T12:48:20.762Z] 12:48:20     INFO - Focus, change scroll position and blur, to ensure proper restore
[task 2024-08-16T12:48:20.763Z] 12:48:20     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_UrlbarInput_overflow.js | Check the overflow side - "left" == "left" - 

TEST-PASS | browser/components/urlbar/tests/browser/browser_UrlbarInput_searchTerms_searchModeSwitcher.js | Extension ID of search provider should be set - "nondefault@tests.mozilla.org" == true - 
[task 2024-08-16T11:14:55.117Z] 11:14:55     INFO - Leaving setup bound 
[task 2024-08-16T11:14:55.119Z] 11:14:55     INFO - Entering test bound visibility_of_elements
[task 2024-08-16T11:14:55.120Z] 11:14:55     INFO - Waiting for the urlbar view to open
[task 2024-08-16T11:14:55.121Z] 11:14:55     INFO - Urlbar view opened
[task 2024-08-16T11:14:55.121Z] 11:14:55     INFO - Buffered messages logged at 11:14:55
[task 2024-08-16T11:14:55.124Z] 11:14:55     INFO - Load a tab with search terms persisting in the urlbar.
[task 2024-08-16T11:14:55.125Z] 11:14:55     INFO - Buffered messages finished
[task 2024-08-16T11:14:55.127Z] 11:14:55     INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_UrlbarInput_searchTerms_searchModeSwitcher.js | Search string should be the urlbar value. - "www.example.com/?q=chocolate+cake" == "chocolate cake" - 
[task 2024-08-16T11:14:55.127Z] 11:14:55     INFO - Stack trace:
[task 2024-08-16T11:14:55.127Z] 11:14:55     INFO - chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/head.js:assertSearchStringIsInUrlbar:319
[task 2024-08-16T11:14:55.127Z] 11:14:55     INFO - chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/head.js:searchWithTab:381
[task 2024-08-16T11:14:55.127Z] 11:14:55     INFO - chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_UrlbarInput_searchTerms_searchModeSwitcher.js:visibility_of_elements:44
[task 2024-08-16T11:14:55.127Z] 11:14:55     INFO - chrome://mochikit/content/browser-test.js:handleTask:1145
[task 2024-08-16T11:14:55.127Z] 11:14:55     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1217
[task 2024-08-16T11:14:55.128Z] 11:14:55     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1358
[task 2024-08-16T11:14:55.128Z] 11:14:55     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1134
[task 2024-08-16T11:14:55.128Z] 11:14:55     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2024-08-16T11:14:55.128Z] 11:14:55     INFO - Not taking screenshot here: see the one that was previously logged
[task 2024-08-16T11:14:55.141Z] 11:14:55     INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_UrlbarInput_searchTerms_searchModeSwitcher.js | Search terms should match. - "" == "chocolate cake" - 
[task 2024-08-16T11:14:55.141Z] 11:14:55     INFO - Stack trace:
[task 2024-08-16T11:14:55.141Z] 11:14:55     INFO - chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/head.js:assertSearchStringIsInUrlbar:324
[task 2024-08-16T11:14:55.141Z] 11:14:55     INFO - chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/head.js:searchWithTab:381
[task 2024-08-16T11:14:55.141Z] 11:14:55     INFO - chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_UrlbarInput_searchTerms_searchModeSwitcher.js:visibility_of_elements:44
[task 2024-08-16T11:14:55.141Z] 11:14:55     INFO - chrome://mochikit/content/browser-test.js:handleTask:1145
[task 2024-08-16T11:14:55.141Z] 11:14:55     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1217
[task 2024-08-16T11:14:55.141Z] 11:14:55     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1358
[task 2024-08-16T11:14:55.141Z] 11:14:55     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1134
[task 2024-08-16T11:14:55.141Z] 11:14:55     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2024-08-16T11:14:55.142Z] 11:14:55     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_UrlbarInput_searchTerms_searchModeSwitcher.js | userTypedValue should match. - null == null -
Flags: needinfo?(jteow)

The reason why it was failing in Beta was because
security.insecure_connection_text.enabled is only enabled in Nightly.

Assignee: nobody → jteow
Status: NEW → ASSIGNED
Pushed by jteow@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/980eb417ca2a Fix CSS of urlbar-input in overflow states - r=dao,desktop-theme-reviewers,urlbar-reviewers
Flags: needinfo?(jteow)

The patch was tested in today's beta simulations. It seems that the patch works for central as early beta simulation but it does not fix the failures from late beta -> central as late beta simulation here.

Hi James! Can you please take another look at this?
Thank you!

Flags: needinfo?(jteow)

Ah my apologies, I missed this error when it was mentioned in comment 1.

The Persistent Search Terms feature is enabled until late beta, hence
why the test is failing late beta and beyond.

I might've integrated the PST with scotchBonnet.enableOverride but
it seems like there's some open threads right now (e.g. should the
feature work on non-default search engines, background colour choice)
that I'm hesistant on making it a blocker to Scotch Bonnet.

Pushed by jteow@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0f746b08fc21 Ensure the Persisted Search Terms pref is enabled in the Unified Search Button test - r=adw,urlbar-reviewers

https://hg.mozilla.org/mozilla-central/rev/980eb417ca2a

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox131: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 131 Branch
Flags: needinfo?(jteow)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: