1913536 - CSS value suggestion for white-space doesn't include normal, pre, pre-line, pre-wrap

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect)

Description

[Kevin Locke]

With Firefox 124 and later, including the latest Nightly, the CSS values suggested by the rules editor in the inspector for the white-space property do not include the values normal, pre, pre-line, or pre-wrap. These values were specified by CSS3 (some as far back as CSS 1) and are also specified by CSS4 as "shorthand's special keywords". These values were suggested in Firefox 123 and earlier and are suggested by Edge and Chrome.

I've bisected the regression to https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=97b5cf7504be3be23cfe6a762a5a02fd27a49673&tochange=677bc5b3f7e679611868078e420607385d4ca20e indicating Bug 1852478 is the regressor, which makes sense as the missing values are not valid for the properties for which white-space is a shorthand.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:jfkthame, since you are the author of the regressor, bug 1852478, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1913536 - Expose the special shorthands in the SpecifiedValueInfo for the CSS white-space shorthand. r=#style

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1852478

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5438ea2a944e
Expose the special shorthands in the SpecifiedValueInfo for the CSS white-space shorthand. r=firefox-style-system-reviewers,devtools-reviewers,emilio

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/5438ea2a944e

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jfkthame, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox130 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1913536 - Expose the special shorthands in the SpecifiedValueInfo for the CSS white-space shorthand.

Original Revision: https://phabricator.services.mozilla.com/D219426

Comment 8

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: missing some autocomplete values in devtools
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: n/a
• Risk associated with taking this patch: minimal
• Explanation of risk level: simple patch to add the special shorthand values to the list
• String changes made/needed: none
• Is Android affected?: yes

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/9e538657b9bf

Comment 10

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1913536 - Expose the special shorthands in the SpecifiedValueInfo for the CSS white-space shorthand. r=#style

Original Revision: https://phabricator.services.mozilla.com/D219426

Comment 11

[Phabricator Automation]

esr128 Uplift Approval Request

• User impact if declined: DevTools fails to show some of the valid values for CSS white-space
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: n/a
• Risk associated with taking this patch: minimal
• Explanation of risk level: stylo change just exposes additional valid values for the property
• String changes made/needed: none
• Is Android affected?: yes

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/24e8110f76bd