1913599 - Sites that depend on legacy createEncodedStreams()

Status: RESOLVED FIXED

(Web Compatibility :: Knowledge Base, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

https://web.archive.org/web/20201017154456/https://w3c.github.io/webrtc-insertable-streams/

Comment 1

[James Graham [:jgraham]]

Is this different to https://bugzilla.mozilla.org/show_bug.cgi?id=1835405 and is there a core bug other than https://bugzilla.mozilla.org/show_bug.cgi?id=1631263 ?

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

They seem the same to me (createEncodedStream() is Chrome's outdated API for RTCRtpScriptTransform).

Comment 3

[Jeff Muizelaar [:jrmuizel]]

This bug is for tracking sites that use Chrome's outdated API

Comment 4

[Pranav bhattarai]

I had to install & use Chromium to receive the video calls on Facebook last year because of this bug. I am commenting to know when I don't have to do that.

Comment 5

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Bug 1913599 - Interventions for some websites relying on createEncodedStreams(). r?twisniewski

Comment 6

[kanapa1]

Could you also add bug 1898293 (messenger.com) to the list of bugs that depend on this one, please?

Comment 7

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

I made bug 1898293 depend on bug 1896361 which in turn depends on this issue.

Comment 8

[kanapa1]

Looking back at this a week later, I think that linking those Bugzilla issues together was probably unnecessary after all. I apologize for any trouble this may have caused.

When I asked to do so at the time, I simply wanted to point out that (based on my observations at least) the standalone Messenger web app available at messenger.com appeared to use the same encryption mechanism as Messenger on Facebook (facebook.com/messages/), and therefore seemed to align perfectly with the title of this bug here, i.e. "Sites that depend on legacy createEncodedStreams()."

However, as :pehrsons rightly noted, bug 1898293 isn't really about E2E encryption issues, so it may not be the best candidate to be linked to in about:compat for the createEncodedStreams() shim. Instead, a better approach might be to update the existing facebook.com-related intervention and modify it as follows (or something along those lines):

--- a/browser/extensions/webcompat/data/interventions.json
+++ b/browser/extensions/webcompat/data/interventions.json
@@ -5226,11 +5226,11 @@
     ]
   },
   "1896361": {
-    "label": "facebook.com",
+    "label": "Meta Messenger",
     "bugs": {
       "1896361": {
         "issue": "broken-interactive-elements",
-        "matches": ["https://www.facebook.com/*"]
+        "matches": ["*://www.facebook.com/*", "*://www.messenger.com/*"]
       }
     },
     "interventions": [

(And then optionally adjust the title of bug 1896361 a bit to reflect that messenger.com is also affected, mainly for stable Firefox users who get to that bug from the about:compat page.)

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d2c66790e1eb
https://hg.mozilla.org/integration/autoland/rev/1ba949c32e98
Interventions for some websites relying on createEncodedStreams(). r=twisniewski,webcompat-reviewers

Comment 10

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/1ba949c32e98