1913611 - The buttons property of contextmenu events is always 0 on Windows/Linux

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[michael_773]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:129.0) Gecko/20100101 Firefox/129.0

Steps to reproduce:

An addon I have has a feature where I can press right click while holding left click to trigger things to happen. This is generally called a rocker gesture.

Prior to today, event.buttons was 1 whenever I did this, indicating left click was held.

Pasting this line into the console is enough to reproduce the effect.

document.addEventListener("contextmenu", event => console.log(event.buttons));

Actual results:

event.buttons returns 0 when I press right click while holding left click.

Expected results:

event.buttons should be 1 when I press right click while holding left click.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Indeed, but it's odd, we initialize .buttons as expected...
https://searchfox.org/mozilla-central/rev/e51b2630b44a8836a7ff35a876a2d8b555041d4a/widget/windows/nsWindow.cpp#5424,5454-5457
https://searchfox.org/mozilla-central/rev/e51b2630b44a8836a7ff35a876a2d8b555041d4a/widget/windows/nsWindow.cpp#4282
https://searchfox.org/mozilla-central/rev/e51b2630b44a8836a7ff35a876a2d8b555041d4a/widget/windows/KeyboardLayout.cpp#887,896,912-913,915-916,918-919

It could be a limitation of Windows.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Ah, this is a regression of bug 1675847.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1675847

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Linux build also has same bug, but macOS build does not.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1913611 - Make `ModifierKeyState::InitInputEvent` and `KeymapWrapper::InitInputEvent` set `WidgetMouseEventBase::mButtons` of `eContextMenu` r=smaug!

They do it only when given event class is expected one but they don't include
ePointerEventClass which is newly used for eContextMenu event since
bug 1675847.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ce2b8c89f13
Make `ModifierKeyState::InitInputEvent` and `KeymapWrapper::InitInputEvent` set `WidgetMouseEventBase::mButtons` of `eContextMenu` r=smaug

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/2ce2b8c89f13

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:masayuki, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox130 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 9419902 [details]
Bug 1913611 - Make ModifierKeyState::InitInputEvent and KeymapWrapper::InitInputEvent set WidgetMouseEventBase::mButtons of eContextMenu r=smaug!

Beta/Release Uplift Approval Request

• User impact if declined: Web apps which refer MouseEvent.buttons of click/auxclick/contextmenu may not work on Windows and Linux. However, it's rare to refer it due to detecting chorded buttons operation of pointing device.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just added to make the value initialized when the event is WidgetPointerEvent class which is newly used for click/autclick/contextmenu events (which were WidgetMouseEvent before).
• String changes made/needed:
• Is Android affected?: No

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9419902 [details]
Bug 1913611 - Make ModifierKeyState::InitInputEvent and KeymapWrapper::InitInputEvent set WidgetMouseEventBase::mButtons of eContextMenu r=smaug!

Approved for 130.0rc1.

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/0cbccb9523d9