1913704 - Remove Firefox Pioneer code

Status: RESOLVED FIXED

(Firefox :: Pioneer, task)

Description

[:Gijs (out for now; he/him)]

There are at least the following bits of code:

• everything under browser/components/ion/
• toolkit/components/telemetry/docs/data/pioneer-study.rst
• a number of pioneerId/pioneer_id references in telemetry code, e.g. in toolkit/components/telemetry/app/TelemetryControllerParent.sys.mjs, toolkit/components/telemetry/app/TelemetryEnvironment.sys.mjs, toolkit/components/extensions/schemas/telemetry.json,
• the about:ion reference in https://searchfox.org/mozilla-central/rev/396a6123691f7ab3ffb449dcbe95304af6f9df3c/browser/components/about/AboutRedirector.cpp#163-165 .

Based on earlier conversations with rhelmer, I believe all of this can be safely removed. Rob, could you confirm just to be on the safe side? :-)

Comment 1

[Robert Helmer [:rhelmer]]

(In reply to :Gijs (he/him) from comment #0)

There are at least the following bits of code:

• everything under browser/components/ion/
• toolkit/components/telemetry/docs/data/pioneer-study.rst
• a number of pioneerId/pioneer_id references in telemetry code, e.g. in toolkit/components/telemetry/app/TelemetryControllerParent.sys.mjs, toolkit/components/telemetry/app/TelemetryEnvironment.sys.mjs, toolkit/components/extensions/schemas/telemetry.json,
• the about:ion reference in https://searchfox.org/mozilla-central/rev/396a6123691f7ab3ffb449dcbe95304af6f9df3c/browser/components/about/AboutRedirector.cpp#163-165 .

Based on earlier conversations with rhelmer, I believe all of this can be safely removed. Rob, could you confirm just to be on the safe side? :-)

Yes, safe to remove. Thanks!

Comment 2

[:Gijs (out for now; he/him)]

How much of the submitEncryptedPing and study_name (cf. here) bits are useful without pioneer? (added in bug 1634557)

Looks like this was exposed to extensions - presumably only because of pioneer? Should the entire API be removed, or should we strip the pioneer ID and/or study_name bits but keep it around otherwise? I'm guessing that because this is legacy telemetry, perhaps we should remove all of it?

Comment 3

[:Gijs (out for now; he/him)]

(If we need to keep the API, I'm particularly unclear on whether study_name has value without the pioneer bits)

Comment 4

[Robert Helmer [:rhelmer]]

I think it can be removed entirely if there are no other callers in-tree, it's possible to do this using Glean.js from a content process now.

Comment 5

[:Gijs (out for now; he/him)]

Attachment: Bug 1913704 - remove pioneer/ion now that it's been retired, r?rhelmer!,#firefox-desktop-core-reviewers!,#extension-reviewers!,chutten!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49e073b1e7ee
remove pioneer/ion now that it's been retired, r=rhelmer,chutten,firefox-desktop-core-reviewers ,extension-reviewers,desktop-theme-reviewers,emilio,mossop,robwu

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/49e073b1e7ee