1913935 - Text-Fragments: Adjust test for scroll-to-text-fragment-open-link-in-new-tab-desktop.html to work with macOS

Status: VERIFIED FIXED

(Core :: DOM: Navigation, defect)

Description

[Jan Jaeschke [:jjaschke]]

The test was introduced in Bug 1911339 and does not work on macOS because it uses CTRL+Enter to open a link in a new tab instead of CMD+Enter.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1911339

Comment 2

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1913935 - Text Fragments: Fixed test to open link in new tab to work on MacOS and moved it into mozilla-specific tests.

Comment 3

[Dianna Smith [:diannaS]]

:jjaschke any update on landing this? As a reminder soft code freeze for fx131 is this week.

Comment 4

[Jan Jaeschke [:jjaschke]]

As Masayuki pointed out, the test doesn’t work as intended in other browser engines, so I’ll try to either fix it in a way other browsers can use it or convert it into a mochitest. However, this patch only changes a test, no gecko code, so it shouldn’t affect the code freeze.

Comment 5

[Hsin-Yi Tsai (she/her)[:hsinyi]]

Change the fx131-status to unaffected as it's test-only change.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1911339

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aaaf48d51fe5
Text Fragments: Fixed test to open link in new tab to work on MacOS and moved it into mozilla-specific tests. r=dom-core,masayuki

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/48388 for changes under testing/web-platform/tests

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/aaaf48d51fe5

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jjaschke, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox132 to wontfix.

For more information, please visit BugBot documentation.

Comment 12

[Jan Jaeschke [:jjaschke]]

It's a test-only change, doesn't require an uplift.

Comment 13

[Dana Lucaci, Desktop QA]

Reproduced with Firefox 130.0a1 (2024-08-02) on macOS 15.
Verified as fixed with Firefox 146.0a1 (20251028094950) and Firefox 145.0b7 (20251027114755) on macOS 15.