1913939 - [wpt-sync] Sync PR 47685 - [EncodedTransform] Detach buffer after writing a frame

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 47685 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/47685
Details from upstream follow.

Lucia <[e-mail]> wrote:

[EncodedTransform] Detach buffer after writing a frame

Add logic for detaching the DOMArrayBuffer frame_data_ after writing
an RTCEncodedAudioFrame or RTCEncodedVideoFrame.

This applies only to streams created with RTCRtpScriptTransform. The behavior of the old API (createEncodedTransform) remains unmodified.

Bug: 354881878

Change-Id: Ia939af54d8dcfeb374cfee834a6519cd63df37c1
Reviewed-on: https://chromium-review.googlesource.com/5789285
WPT-Export-Revision: 5d9f8cd3e154f9e26e6a42d7bf40d631a7c7d67d

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=10b61df4e60007b00893c13d928434d8052eff06

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=afda4ee01a77842dfb413619c3c197d2c6557897

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 4 subtests

Status Summary

Firefox

OK : 1
PASS : 2
FAIL : 2

Chrome

TIMEOUT: 1
ERROR : 1
NOTRUN : 3

Safari

OK : 1
PASS : 2
FAIL : 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /webrtc-encoded-transform/RTCRtpScriptTransform-encoded-transform.https.html [wpt.fyi]
  • Receiver and sender read, modifiy and write video frames.: FAIL (Chrome: TIMEOUT, Safari: FAIL)
  • Receiver and sender read, modifiy and write audio frames.: FAIL (Chrome: NOTRUN, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/809d3a5c610c
[wpt PR 47685] - [EncodedTransform] Detach buffer after writing a frame, a=testonly

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/809d3a5c610c