Closed
Bug 1913948
Opened 1 year ago
Closed 1 year ago
Fold constant int32 when simplifying to MExtendInt32ToInt64
Categories
(Core :: JavaScript Engine: JIT, enhancement, P1)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
131 Branch
| Tracking | Status | |
|---|---|---|
| firefox131 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
Bug 1913948: Fold constant int32 when simplifying to MExtendInt32ToInt64. r=#spidermonkey-reviewers!
48 bytes,
text/x-phabricator-request
|
Details | Review |
Bug 1910769 didn't handle the case when the input is an Int32 constant. This leads to creating MExtendInt32ToInt64(MConstant::Int32(0)) instead of directly using MConstant::Int64(0).
|
Assignee | |
Comment 1•1 year ago
|
||
We don't always re-run GVN, so when folding to MExtendInt32ToInt64, we can't rely
on that MExtendInt32ToInt64::foldsTo will be called to optimise constant inputs.
|
||
Updated•1 year ago
|
Pushed by andre.bargull@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ddc09145f934
Fold constant int32 when simplifying to MExtendInt32ToInt64. r=spidermonkey-reviewers,iain
|
||
Comment 3•1 year ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox131:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 131 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•