1913950 - Add recover support for MInt64ToBigInt

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement, P1)

Description

[André Bargull [:anba]]

Adding recover support for MInt64ToBigInt will allow to (more reliably) omit BigInt allocations when reading from BigInt64Array (and others).

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1913950 - Part 1: Support recovering MIRType::Int64. r=#spidermonkey-reviewers!

The code is based on the existing recover support for boxed values, with the
exception of INT64_CST, which is stored as two Int32Values in the constant
pool.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1913950 - Part 2: Add recover support for MInt64ToBigInt. r=#spidermonkey-reviewers!

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1913950 - Part 3: Remove MInt64ToBigInt special case when loading from BigInt TypedArray. r=#spidermonkey-reviewers!

This is no longer needed now that MInt64ToBigInt is recoverable. We still need
to have this special case for MIonToWasmCall, because MIonToWasmCall's resume
point includes MInt64ToBigInt, but when lowering MIonToWasmCall, the safepoint
assumes all operands covered by the resume point have already been lowered, which
isn't the case for MIonToWasmCall, because MInt64ToBigInt is lowered after
MIonToWasmCall.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8fa5fd04ff4
Part 1: Support recovering MIRType::Int64. r=spidermonkey-reviewers,iain
https://hg.mozilla.org/integration/autoland/rev/ad036d0540b0
Part 2: Add recover support for MInt64ToBigInt. r=spidermonkey-reviewers,iain
https://hg.mozilla.org/integration/autoland/rev/5601a4469a98
Part 3: Remove MInt64ToBigInt special case when loading from BigInt TypedArray. r=spidermonkey-reviewers,iain

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/b8fa5fd04ff4
https://hg.mozilla.org/mozilla-central/rev/ad036d0540b0
https://hg.mozilla.org/mozilla-central/rev/5601a4469a98