1913962 - Frequent warnings from WARNING: '!top', file dom/xul/MenuBarListener.cpp:99

Status: RESOLVED FIXED

(Core :: XUL, task)

Description

[Andrew McCreight [:mccr8]]

18,800 instances of "WARNING: '!top', file dom/xul/MenuBarListener.cpp:99" emitted during macosx1015-64-qr debug testing

18795 WARNING: '!top', file dom/xul/MenuBarListener.cpp:99

This warning shows up in the following test suites:

   480 - test-macosx1015-64-qr/debug-mochitest-browser-chrome-spi-nw-3 bc3
   480 - test-macosx1015-64-qr/debug-mochitest-browser-chrome-3 bc3
   479 - test-macosx1015-64-qr/debug-web-platform-tests-wdspec-4 Wd4
   479 - test-macosx1015-64-qr/debug-web-platform-tests-11 wpt11
   479 - test-macosx1015-64-qr/debug-web-platform-tests-wdspec-headless-4 Wd4
   406 - test-macosx1015-64-qr/debug-mochitest-browser-chrome-spi-nw-5 bc5
   406 - test-macosx1015-64-qr/debug-mochitest-browser-chrome-5 bc5
   366 - test-macosx1015-64-qr/debug-web-platform-tests-crashtest Wc

It shows up in 4208 tests. A few of the most prevalent:

  2855 -        Shutdown
   156 -        /webdriver/tests/classic/new_session/unhandled_prompt_behavior.py
   137 -        dom/tests/browser/browser_noopener.js
    96 -        /webdriver/tests/classic/new_session/create_alwaysMatch.py
    96 -        /webdriver/tests/classic/new_session/create_firstMatch.py
    60 -        browser/components/tabbrowser/test/browser/tabs/browser_window_open_modifiers.js
    54 -        browser/components/privatebrowsing/test/browser/browser_privatebrowsing_windowtitle.js
    47 -        browser/components/privatebrowsing/test/browser/browser_privatebrowsing_zoomrestore.js
    46 -        browser/components/privatebrowsing/test/browser/browser_privatebrowsing_history_shift_click.js
    40 -        layout/base/tests/browser_animatedImageLeak.js

This is the third most common warning on a recent m-c MacOS debug try push.

Comment 1

[Andrew McCreight [:mccr8]]

Emilio, is this warning useful or something we could get rid of? Thanks.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Yeah this seems fine to get rid of.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1913962 - Remove rather noisy warning. r=mccr8

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56d442397269
Remove rather noisy warning. r=mccr8

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/56d442397269