1913971 - Drag and drop not a great experience for pinned tabs in the new sidebar when it's expanded

Status: VERIFIED FIXED

(Firefox :: Sidebar, defect, P1)

Description

[Kelly Cochrane [:kcochrane]]

Drag and drop works great for pinned tabs when the new sidebar is collapsed, but once expanded, the experience is very awkward and doesn't behave how you'd expect.

STR:
Flip the sidebar.revamp pref to true to load the new sidebar.
Pin at least 2 or 3 tabs
Notice how drag and drop works fine for these pinned tabs when the sidebar is still collapsed.
Expand the sidebar using the sidebar toolbar button.
Attempt to rearrange your pinned tabs now and notice how they aren't moving around like you'd expect.

Comment 1

[Sarah Clements [:sclements]]

In the expanded state, the drag n' drop logic for pinned probably needs to use similar logic for horizontal tabs, although you could also drag pinned tabs diagonally within that container depending on how many you have.

Comment 2

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 1913971 - Improve drag experience for pinned tabs in expanded vertical tabs r=#sidebar-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc884b6ba516
Improve drag experience for pinned tabs in expanded vertical tabs r=sidebar-reviewers,sclements,mconley

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/cc884b6ba516

Comment 6

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

I was able to reproduce the issue on an affected Nightly 131.0a1 build from 2024-08-20, using Windows 11, while following the steps from Comment 0.
Verified as fixed with Firefox 132.0b5, on macOS 14.6, Windows 11 and Ubuntu 22.04. Drag and drop works fine for the pinned tabs when the vertical sidebar is expanded.