1913976 - menu_mobileBookmarks folder is missing.

Status: VERIFIED FIXED

(Toolkit :: Places, defect, P1)

Description

[klcb2010]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:129.0) Gecko/20100101 Firefox/129.0

Steps to reproduce:

This folder usually appears when you log in on both mobile devices and a PC and sync them. However, it has now disappeared, and I don't know why. I haven't made any "CSS" changes or installed any extensions or plugins. The current test machine is running Windows 11-24H2-26100-1301.

Actual results:

The bookmark menu folder "menu_mobileBookmarks" in the new Firefox version 129 is no longer visible and seems to have been disabled. Its Chinese name is "移动设备上的书签" (Bookmarks on Mobile Devices). This folder usually appears when you log in on both mobile devices and a PC and sync them. However, it has now disappeared, and I don't know why. I haven't made any "CSS" changes or installed any extensions or plugins. The current test machine is running Windows 11-24H2-26100-1301.

Expected results:

This folder should usually appear when you log in on both mobile devices and a PC and sync them

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Sync' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Mark Hammond [:markh] [:mhammond]]

I think this folder only appears when there are actually bookmarks in that folder. The code is here

Comment 3

[klcb2010]

(In reply to Mark Hammond [:markh] [:mhammond] from comment #2)

I think this folder only appears when there are actually bookmarks in that folder. The code is here

I am certain that there are bookmarks in the 'Mobile Bookmarks' folder, and this issue does not exist in Firefox version 128 and below."

Comment 4

[Mark Hammond [:markh] [:mhammond]]

This is working fine for me on Firefox 131. On your desktop device, what does about:config show for the preference browser.bookmarks.showMobileBookmarks?

Comment 5

[klcb2010]

(In reply to Mark Hammond [:markh] [:mhammond] from comment #4)

This is working fine for me on Firefox 131. On your desktop device, what does about:config show for the preference browser.bookmarks.showMobileBookmarks?

true

Comment 6

[Mark Hammond [:markh] [:mhammond]]

That's odd - it implies Sync agrees there are mobile bookmarks and this pref being true should be all that's necessary for it to appear. I've no idea why it's not being shown for you, but I'll adjust the component because it appears Sync is doing the right thing here.

Comment 7

[digixmax]

(In reply to Mark Hammond [:markh] [:mhammond] from comment #6)

That's odd - it implies Sync agrees there are mobile bookmarks and this pref being true should be all that's necessary for it to appear. I've no idea why it's not being shown for you, but I'll adjust the component because it appears Sync is doing the right thing here.
I can confirm having the same issue (beginning around the last couple of weeks).

My Mobile Bookmarks folder which has dozens of bookmarks just stopped showing up on my desktop FF's bookmark menu. The value of 'browser.bookmarks.showMobileBookmarks' is 'true'.

Comment 8

[Marco Bonardo [:mak]]

Maybe a regression from https://bugzilla.mozilla.org/show_bug.cgi?id=1893068, let me check.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1893068

Comment 10

[Marco Bonardo [:mak]]

Attachment: Bug 1913976 - mobileBookmarks folder is missing in Bookmarks menu. r=tschuster

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57c9b445613e
mobileBookmarks folder is missing in Bookmarks menu. r=places-reviewers,Gijs,Standard8

Comment 12

[Marco Bonardo [:mak]]

Attachment: Bug 1913976 - mobileBookmarks folder is missing in Bookmarks menu. r=tschuster

Original Revision: https://phabricator.services.mozilla.com/D220383

Comment 13

[Phabricator Automation]

release Uplift Approval Request

• User impact if declined: no Mobile bookmarks folder in bookmarks menus
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Sync bookmarks from mobile, check the mobile bookmarks folder appears in the main menubar Bookmarks menu, and in the Bookmarks menu button (must be customized in)
• Risk associated with taking this patch: low
• Explanation of risk level: small fix, the touched code is already broken, has unit test.
• String changes made/needed: none
• Is Android affected?: no

Comment 14

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/57c9b445613e

Comment 15

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/b73ccdf1f861

Comment 16

[Tom Schuster (MoCo)]

Sorry and thanks for fixing this! (I guess I didn't test mobile bookmarks at all, because my test profile didn't have sync enabled...)

Comment 17

[miralobontiu]

Verified that the Mobile Bookmarks folder is displayed, available and updated on sync, on both Firefox Nightly 131.0a1, and Firefox 130.0 build 2.
Verified with Windows 10, and Google Pixel 6 (Android 15).