Closed Bug 1913984 Opened 2 years ago Closed 2 years ago

Share almost duplicate code for branch64 on x86 and ARM32

Categories

(Core :: JavaScript Engine: JIT, task, P1)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
131 Branch
Tracking Flags:
Tracking Status
firefox131 --- fixed

People

(Reporter: anba, Assigned: anba)

References

(Blocks 1 open bug)

Details

Attachments

(1 external file)

Review comment from https://phabricator.services.mozilla.com/D219305 mentioned we should try to reduce the code duplication for branch64 on x86 and ARM32.

Imm64, Register64, and Address all use different approaches to select the
high- resp. low-word. At a later time we should try to unify this, but for now
only reduce the near duplicated code for branch64 on x86 and ARM32.

Blocks: sm-jits
Severity: -- → N/A
Priority: -- → P1
Pushed by andre.bargull@gmail.com: https://hg.mozilla.org/integration/autoland/rev/bc201a654aca Share branch64 code for x86 and ARM32. r=iain

https://hg.mozilla.org/mozilla-central/rev/bc201a654aca

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox131: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 131 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: