Closed
Bug 1914141
Opened 1 year ago
Closed 1 year ago
Services.io.isValidHostname("invalid.192.168.1.2"); claims it's is valid when it's not
Categories
(Core :: Networking, defect, P2)
Core
Networking
Tracking
()
RESOLVED
FIXED
132 Branch
| Tracking | Status | |
|---|---|---|
| firefox132 | --- | fixed |
People
(Reporter: mkmelin, Assigned: edgul)
References
Details
(Whiteboard: [necko-triaged][necko-priority-queue])
Attachments
(1 file)
Bug 1723456 made hostnames like "invalid.192.168.1.2" invalid. Services.io.isValidHostname("invalid.192.168.1.2"); claims it's valid.
xref bug 1911951 comment 16.
|
||
Comment 1•1 year ago
|
||
FYI Sean
Severity: -- → S3
Flags: needinfo?(sekim)
Priority: -- → P2
Whiteboard: [necko-triaged][necko-priority-new]
We will add a similar check to Services.io.isValidHostname and rename net_IsValidHostName
Assignee: nobody → edgul
Flags: needinfo?(edgul)
Whiteboard: [necko-triaged][necko-priority-new] → [necko-triaged][necko-priority-next]
Whiteboard: [necko-triaged][necko-priority-next] → [necko-triaged][necko-priority-queue]
Pushed by eguloien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/975a09aa6dc9
Added an ending-in-number check for non-ipv4 domains for Services.io.isValidHostname. r=necko-reviewers,valentin
|
||
Comment 6•1 year ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox132:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 132 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•