1914154 - Sidebar vertical tabs scrollbar doesn't always autohide

Status: VERIFIED FIXED

(Core :: Layout: Scrolling and Overflow, defect)

Description

[Stuart Colville [:muffinresearch]]

Attachment: win-scrollbar.png

STR:

• With sidebar.revamp and sidebar.verticalTabs enabled in Nightly.
• With enough tabs to be scrollable and move the mouse off of the sidebar and you will find it's possible to have the sidebar scrollbar remain visible.
• Seems to be a bit easier to reproduce with a longer bar for scrolling and scrolling to the bottom before switching to settings.
• Note this can be difficult to reproduce and take several attempts to get the issue.

What Happens

The scrollbar sometimes remains visible rather than disappearing.

What should happen

The scrollbar should autohide.

Platforms:

I can reproduce this in Nightly Mac, Windows and Linux. See screenshots.

• Windows 11: 131.0a1 (2024-08-20) (64-bit)
• Ubuntu 22.04: 130.0a1 (2024-08-03) (64-bit) - Deb package.
• Mac OS: 131.0a1 (2024-08-20) (64-bit)

Comment 1

[Stuart Colville [:muffinresearch]]

Attachment: linux-scrollbar.png

Comment 2

[Stuart Colville [:muffinresearch]]

Attachment: mac-scrollbar.png

Comment 3

[Sam Foster [:sfoster] (he/him)]

Does this still reproduce? I have a vague memory of a similar issue being fixed elsewhere recently...

Comment 4

[Sam Foster [:sfoster] (he/him)]

I might be thinking of bug 1915599. Not sure if that is relevant here.

Comment 5

[Sarah Clements [:sclements]]

I can still reproduce it on mac; If I scroll up and then down and hover over the scrollbar it seems to get stuck in the hover state (even after rebasing on changes from bug 1915599 and with my fix for bug 1913279).

Comment 6

[Dão Gottwald [:dao]]

This looks suspicious: https://searchfox.org/mozilla-central/rev/cc01f11adfacca9cd44a75fd140d2fdd8f9a48d4/browser/themes/shared/tabbrowser/tabs.css#835-836
Does removing this perhaps help with the behavior here?

Comment 7

[Sarah Clements [:sclements]]

Playing around with it in the devtools inspect it does seem like removing it does solve the issue, from what I can see. I had added that initially because there was a noticeable gap between the scrollbar and the edge of the container, but now with the changes to the styling its less perceptible.

Comment 8

[Sarah Clements [:sclements]]

Looks like bug 1916954 removed the negative margin.

Comment 9

[Stuart Colville [:muffinresearch]]

I can still repro with a build that includes the negative margin removal.

Comment 10

[Stuart Colville [:muffinresearch]]

Interesting side note: This isn't reproducible with reduce-motion enabled in OS accessibility settings (accessibility -> display) on OSX. Also the scrollbar seems a lot more snappy with animations off (which is perhaps to be expected) but still worth noting.

Comment 11

[Stuart Colville [:muffinresearch]]

Hi Emilio, I was wondering if you'd have any suggestions or thoughts on what could be the cause of this issue? As well as the STR see the note in Comment 10 that reduce motion seems to stop it being triggered.

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1914154 - Fix how we deal with APZ scrollbar activity. r=botond,dlrobertson,hiro

For the vertical tab bar, probably due to how it re-implements
scrolling1, we get multiple eTransformBegin state changes, but a
single eTransformEnd.

That ends up with a permanently-positive activity counter, which leaves
the scrollbar visible.

There might be an underlying APZ bug here, not sure if mismatched events
are expected, but it seems other handlers deal with this mostly
correctly, and the fix on layout's end is rather trivial, too, so this
seems worth doing.

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The product::component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit BugBot documentation.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f33a5b1ae476
Fix how we deal with APZ scrollbar activity. r=hiro

Comment 15

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f33a5b1ae476

Comment 16

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Attachment: bandicam 2024-10-10 14-42-30-450.mp4

I am still able to reproduce the issue intermittently, on Firefox 132.0b5, using macOS 14.7, as described in Comment 5. The scrollbar remains visible even after moving the mouse around.
Also, I can reproduce it on Windows 11 with the same Firefox version if I release the click outside of the tab strip area, after scrolling up or down - please see the attached video - but the scrollbar hides as soon as I move the mouse again.
@emilio, should we reopen this? Thanks in advance!

Comment 17

[Emilio Cobos Álvarez (:emilio)]

Can you open another bug? The root cause is very likely different.

Comment 18

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #17)

Can you open another bug? The root cause is very likely different.

Yes, of course. Logged bug 1924079.
And regarding this issue, I am unable to reproduce it with Firefox 132.0b5 while following the steps from Comment 0, but I am still able to reproduce it on macOS 14.7 as mentioned in Comment 5. I will attach a video as well. Should we also track this separately?

Comment 19

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Attachment: scrollbar still visible on macOS as described in Comment 5

Comment 20

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

@Emilio, regarding Comment 18, should we reopen this ticket as I am still able to reproduce the issue on Firefox 132, on macOS 14.7, as described in Comment 5? Thanks!

Comment 21

[Emilio Cobos Álvarez (:emilio)]

The original bug was reproducible on Linux and Windows, and I can't repro it there, so no, separate bug please.

Comment 22

[Emilio Cobos Álvarez (:emilio)]

(Please ni? me on the new bug, I think I might know what's going on, hover in macOS scrollbars is generally sticky but we should still clear the stickiness on mouseout...)

Comment 23

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Thank you for the confirmation!
I am also unable to reproduce the issue on Firefox 132.0b8 using Windows 11 and Ubuntu 22.04 as described in Comment 0. Marking this verified as fixed.
Logged bug 1925564 for the macOS behavior.