1914331 - Enable using DAP with OHTTP

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement)

Comment 1

[Simon Friedberger (:simonf)]

Attachment: Bug 1914331: HPKE config fetching with OHTTP r=tcampbell

Comment 2

[Simon Friedberger (:simonf)]

Attachment: Bug 1914331 - Use DAP-over-OHTTP for PrivateAttributionService r?dmueller

Comment 3

[Ted Campbell [:tcampbell]]

Attachment: Bug 1914331 - Use an option bag for sendDAPMeasurement r?dmueller

To prepare for more configuration options, use an option object parameter for
additional optional parameters.

Comment 4

[Ted Campbell [:tcampbell]]

Attachment: Bug 1914331 - Separate key fetch from report generation in DAPTelemetrySender r?dmueller

Comment 5

[Ted Campbell [:tcampbell]]

Attachment: Bug 1914331 - Support ArrayBuffer uploads in ObliviousHTTP.sys.mjs r?#necko-reviewers

Later patches will transmit DAP reports which are binary data so this adds
support for ArrayBuffer to the ohttpRequest code. Also support the 'PUT' method.

Comment 6

[Ted Campbell [:tcampbell]]

Attachment: Bug 1914331 - Support pinned keys in HPKEConfigManager r?#necko-reviewers

In some cases (such as DAP-over-OHTTP) it may be preferable to ship the HPKE
rather than trying to fetch it over the network for better privacy.

Comment 7

[Ted Campbell [:tcampbell]]

Attachment: Bug 1914331 - Add OHTTP support to DAPTelemetrySender r?dmueller

Add support for DAPTelemetrySender to submit reports over OHTTP. When this mode
is used, the caller is responsible for provisioning the DAP keys in a privacy
conscious way.

Comment 8

[Ted Campbell [:tcampbell]]

Attachment: Bug 1914331 - Add a testcase for PPA with DAP-over-OHTTP r?dmueller

This uses a mock OHTTP server to check flow of reports.

Comment 9

[Ted Campbell [:tcampbell]]

Local testing works successfully from PrivateAttribtionService.sendDapReport -> OHTTP[Fastly;Mozilla;prod] -> DAP[Divviup;prod] -> DAP[Mozilla;stage] -> janus-cli::collector.

Comment 10

[Ted Campbell [:tcampbell]]

Attachment: Bug 1914331 - Support PPA-over-DAP-over-OHTTP r?gijs!,dmueller!

• Update the DAPTelemetrySender to provision DAP HPKE keys from prefs and allow
  Nimbus to update them if a key-rotation is needed. This removes fetching of
  such keys from the '/hpke_config' endpoints. The DAP preferences are also
  renamed slightly for consistency.
• The DAPTelemetrySender can optionally take an OHTTP configuration which can be
  used to upload reports.
• The PrivateAttributionService component now requires OHTTP for DAP uploads and
  uses the servers that the Shopping component configures.
• Add support to ObliviousHTTP.sys.mjs to allow uploading from ArrayBuffers and
  also to support the PUT verb.
• The DAPTelemetrySender interface is updated to pass extra options in an
  options bag parameter.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb9ce57dfc32
Support PPA-over-DAP-over-OHTTP r=Gijs,dmueller

Comment 12

[Serban Stanca [:SerbanS]]

Backed out for causing xpcshell failures in test_fetchImage.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | toolkit/components/shopping/test/xpcshell/test_fetchImage.js | xpcshell return code: 0

Comment 13

[Ted Campbell [:tcampbell]]

My fix for a review nit was incorrect. No major problems.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5dbb861c3ad
Support PPA-over-DAP-over-OHTTP r=Gijs,dmueller

Comment 15

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/f5dbb861c3ad

Comment 16

[Dianna Smith [:diannaS]]

:simonf is this something you want to include in the 131 release notes? (Nomination Process)

Comment 17

[Simon Friedberger (:simonf)]

:diannaS No, this is an internal change.