1914450 - Bring changes in 1913311 to the encoder

Status: RESOLVED FIXED

(Core :: Audio/Video: Web Codecs, defect, P1)

Description

[C.M.Chang[:chunmin]]

Theoretically, the crash pattern in bug 1913311 could also happen on the encoder side since the encoder's architecture is symmetric to the decoder's. Therefore, the changes in bug 1913311 for DecodeAgent should also be applied to the EncoderAgent.

Comment 1

[C.M.Chang[:chunmin]]

Attachment: Bug 1914450 - Prohibit shut DecoderAgent down while it's shutting down

Comment 2

[C.M.Chang[:chunmin]]

Attachment: Bug 1914450 - Allow calling EncoderAgent::Shutdown without active MediaDataEncoder

This patch addresses a potential crash that could occur if
EncodeAgent::Shutdown is called after PEMFactory fails to create an encoder in EncoderAgent::Configure`, leading to a failed assertion due
to the absence of the expected encoder. This crash pattern is similar to
the one described in bug 1913311.

To resolve this issue, the same method used in bug 1913311 has been
applied. This patch ensures that Encoder::Shutdown can be safely
called even when the MediaDataEncoder is no present, preventing the
crash from occuring.

Depends on D219912

Comment 3

[C.M.Chang[:chunmin]]

Attachment: Bug 1914450 - Revise comment for DecoderAgent::Shutdown w/o a decoder

Depends on D219913

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1400a9d3f766
Prohibit shut DecoderAgent down while it's shutting down r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/41fc8585ac30
Allow calling EncoderAgent::Shutdown without active MediaDataEncoder r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/460b6005a451
Revise comment for DecoderAgent::Shutdown w/o a decoder r=media-playback-reviewers,padenot

Comment 5

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/1400a9d3f766
https://hg.mozilla.org/mozilla-central/rev/41fc8585ac30
https://hg.mozilla.org/mozilla-central/rev/460b6005a451