Closed Bug 1914529 Opened 10 months ago Closed 10 months ago

[wpt-sync] Sync PR 47758 - WebNN: Fixed resetAfter option of gru operator in DirectML backend

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox131 fixed)

RESOLVED FIXED
131 Branch
Tracking Status
firefox131 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 47758 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/47758
Details from upstream follow.

Miao Bin <bin.miao@intel.com> wrote:

WebNN: Fixed resetAfter option of gru operator in DirectML backend

This CL fixes the implementation of the resetAfter option of the gru
operator in the DirectML backend. After the modification, the gru
operator in the DirectML backend will have the same behavior as other
backends such as tflite.

Since the conformance tests of gru and gruCell operators are based on
the existing gru test of ONNX CTS, and the default value of
linear_before_reset in ONNX is false whereas the default value of
resetAfter in WebNN is true, we should explicitly set the resetAfter
parameter to false in the test case when the linear_before_reset is
not set by ONNX CTS. This CL also modifies the WPT conformance test of
gru and gruCell.

Bug: 359628066
Change-Id: I70feee5bc67d894b2823cc4f4881b77d4e0edd91
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel, linux-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/5789662
WPT-Export-Revision: 14d85a5a6d8cb908114356141ba946d6503b58d7

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Safari on GitHub CI

Total 12 tests and 1 subtests

Status Summary

Safari

OK : 12
FAIL: 12

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e3c090de0ee7 [wpt PR 47758] - WebNN: Fixed resetAfter option of gru operator in DirectML backend, a=testonly
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → 131 Branch
You need to log in before you can comment on or make changes to this bug.